Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Mon, Dec 12, 2016 at 12:34 PM, Brian Norris wrote: > Hi all, > > On Mon, Dec 12, 2016 at 08:47:06AM -0600, Rob Herring wrote: > > [Snip Benjamin's proposal; I agree we don't really want a multi-level DT > layout purely for making the driver look a little nicer (I'm

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Mon, Dec 12, 2016 at 12:34 PM, Brian Norris wrote: > Hi all, > > On Mon, Dec 12, 2016 at 08:47:06AM -0600, Rob Herring wrote: > > [Snip Benjamin's proposal; I agree we don't really want a multi-level DT > layout purely for making the driver look a little nicer (I'm not sure > this would really

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi all, On Mon, Dec 12, 2016 at 08:47:06AM -0600, Rob Herring wrote: [Snip Benjamin's proposal; I agree we don't really want a multi-level DT layout purely for making the driver look a little nicer (I'm not sure this would really be nicer anyway). And I think, as Rob notes here, our disagreement

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi all, On Mon, Dec 12, 2016 at 08:47:06AM -0600, Rob Herring wrote: [Snip Benjamin's proposal; I agree we don't really want a multi-level DT layout purely for making the driver look a little nicer (I'm not sure this would really be nicer anyway). And I think, as Rob notes here, our disagreement

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Mon, Dec 12, 2016 at 4:01 AM, Benjamin Tissoires wrote: > On Dec 12 2016 or thereabouts, Jiri Kosina wrote: >> Given the timing (merge window being open) and given then NACK given by >> Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now >>

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Mon, Dec 12, 2016 at 4:01 AM, Benjamin Tissoires wrote: > On Dec 12 2016 or thereabouts, Jiri Kosina wrote: >> Given the timing (merge window being open) and given then NACK given by >> Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now >> obsolete, and has been superseded

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Dec 12 2016 or thereabouts, Jiri Kosina wrote: > Given the timing (merge window being open) and given then NACK given by > Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now > obsolete, and has been superseded by for-4.10/i2c-hid-nopower). > > However, this is mostly

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Dec 12 2016 or thereabouts, Jiri Kosina wrote: > Given the timing (merge window being open) and given then NACK given by > Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now > obsolete, and has been superseded by for-4.10/i2c-hid-nopower). > > However, this is mostly

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Given the timing (merge window being open) and given then NACK given by Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now obsolete, and has been superseded by for-4.10/i2c-hid-nopower). However, this is mostly done in order to provide more time for discussion; I still

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Given the timing (merge window being open) and given then NACK given by Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now obsolete, and has been superseded by for-4.10/i2c-hid-nopower). However, this is mostly done in order to provide more time for discussion; I still

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Fri, Dec 9, 2016 at 10:05 AM, Doug Anderson wrote: > Hi, > > On Thu, Dec 8, 2016 at 8:01 AM, Rob Herring wrote: >>> Just my $0.02. Feel free to ignore. >>> >>> One thought is that I would say that the need to power on the device >>> explicitly seems

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Fri, Dec 9, 2016 at 10:05 AM, Doug Anderson wrote: > Hi, > > On Thu, Dec 8, 2016 at 8:01 AM, Rob Herring wrote: >>> Just my $0.02. Feel free to ignore. >>> >>> One thought is that I would say that the need to power on the device >>> explicitly seems more like a board level difference and

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi, On Fri, Dec 9, 2016 at 7:01 AM, Rob Herring wrote: > On Fri, Dec 9, 2016 at 8:36 AM, Jiri Kosina wrote: >> On Thu, 8 Dec 2016, Rob Herring wrote: >> >>> > And if tomorrow there is Elan device that is drop-in compatible (same >>> > connector, etc) with

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi, On Fri, Dec 9, 2016 at 7:01 AM, Rob Herring wrote: > On Fri, Dec 9, 2016 at 8:36 AM, Jiri Kosina wrote: >> On Thu, 8 Dec 2016, Rob Herring wrote: >> >>> > And if tomorrow there is Elan device that is drop-in compatible (same >>> > connector, etc) with Wacom i2c-hid, will you ask for

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi, On Thu, Dec 8, 2016 at 8:01 AM, Rob Herring wrote: >> Just my $0.02. Feel free to ignore. >> >> One thought is that I would say that the need to power on the device >> explicitly seems more like a board level difference and less like a >> difference associated with a

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi, On Thu, Dec 8, 2016 at 8:01 AM, Rob Herring wrote: >> Just my $0.02. Feel free to ignore. >> >> One thought is that I would say that the need to power on the device >> explicitly seems more like a board level difference and less like a >> difference associated with a particular digitizer.

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Fri, Dec 9, 2016 at 8:36 AM, Jiri Kosina wrote: > On Thu, 8 Dec 2016, Rob Herring wrote: > >> > And if tomorrow there is Elan device that is drop-in compatible (same >> > connector, etc) with Wacom i2c-hid, will you ask for Elan-specific >> > binding? Atmel? Weida? They all

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Fri, Dec 9, 2016 at 8:36 AM, Jiri Kosina wrote: > On Thu, 8 Dec 2016, Rob Herring wrote: > >> > And if tomorrow there is Elan device that is drop-in compatible (same >> > connector, etc) with Wacom i2c-hid, will you ask for Elan-specific >> > binding? Atmel? Weida? They all need to be powered

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 8, 2016 at 12:12 PM, Dmitry Torokhov wrote: > On Thu, Dec 08, 2016 at 10:26:41AM -0600, Rob Herring wrote: >> On Thu, Dec 8, 2016 at 10:13 AM, Dmitry Torokhov >> wrote: >> > On December 8, 2016 8:03:06 AM PST, Rob Herring

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 8, 2016 at 12:12 PM, Dmitry Torokhov wrote: > On Thu, Dec 08, 2016 at 10:26:41AM -0600, Rob Herring wrote: >> On Thu, Dec 8, 2016 at 10:13 AM, Dmitry Torokhov >> wrote: >> > On December 8, 2016 8:03:06 AM PST, Rob Herring wrote: >> >>On Thu, Dec 8, 2016 at 9:41 AM, Benjamin

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, 8 Dec 2016, Rob Herring wrote: > > And if tomorrow there is Elan device that is drop-in compatible (same > > connector, etc) with Wacom i2c-hid, will you ask for Elan-specific > > binding? Atmel? Weida? They all need to be powered up ultimately. > > Yes, I will. What advantage does

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, 8 Dec 2016, Rob Herring wrote: > > And if tomorrow there is Elan device that is drop-in compatible (same > > connector, etc) with Wacom i2c-hid, will you ask for Elan-specific > > binding? Atmel? Weida? They all need to be powered up ultimately. > > Yes, I will. What advantage does

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 08, 2016 at 10:26:41AM -0600, Rob Herring wrote: > On Thu, Dec 8, 2016 at 10:13 AM, Dmitry Torokhov > wrote: > > On December 8, 2016 8:03:06 AM PST, Rob Herring wrote: > >>On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires >

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 08, 2016 at 10:26:41AM -0600, Rob Herring wrote: > On Thu, Dec 8, 2016 at 10:13 AM, Dmitry Torokhov > wrote: > > On December 8, 2016 8:03:06 AM PST, Rob Herring wrote: > >>On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires > >> wrote: > >>> On Dec 06 2016 or thereabouts, Doug

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 8, 2016 at 10:13 AM, Dmitry Torokhov wrote: > On December 8, 2016 8:03:06 AM PST, Rob Herring wrote: >>On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires >> wrote: >>> On Dec 06 2016 or thereabouts, Doug

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 8, 2016 at 10:13 AM, Dmitry Torokhov wrote: > On December 8, 2016 8:03:06 AM PST, Rob Herring wrote: >>On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires >> wrote: >>> On Dec 06 2016 or thereabouts, Doug Anderson wrote: Hi, On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On December 8, 2016 8:03:06 AM PST, Rob Herring wrote: >On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires > wrote: >> On Dec 06 2016 or thereabouts, Doug Anderson wrote: >>> Hi, >>> >>> On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On December 8, 2016 8:03:06 AM PST, Rob Herring wrote: >On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires > wrote: >> On Dec 06 2016 or thereabouts, Doug Anderson wrote: >>> Hi, >>> >>> On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: >>> > On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires wrote: > On Dec 06 2016 or thereabouts, Doug Anderson wrote: >> Hi, >> >> On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: >> > On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires >> >

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 8, 2016 at 9:41 AM, Benjamin Tissoires wrote: > On Dec 06 2016 or thereabouts, Doug Anderson wrote: >> Hi, >> >> On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: >> > On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires >> > wrote: >> >> On Dec 05 2016 or thereabouts, Rob Herring

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Tue, Dec 6, 2016 at 10:18 AM, Doug Anderson wrote: > Hi, > > On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: >> On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires >> wrote: >>> On Dec 05 2016 or thereabouts, Rob

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Tue, Dec 6, 2016 at 10:18 AM, Doug Anderson wrote: > Hi, > > On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: >> On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires >> wrote: >>> On Dec 05 2016 or thereabouts, Rob Herring wrote: On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Dec 06 2016 or thereabouts, Doug Anderson wrote: > Hi, > > On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: > > On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires > > wrote: > >> On Dec 05 2016 or thereabouts, Rob Herring wrote: > >>> On Thu,

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Dec 06 2016 or thereabouts, Doug Anderson wrote: > Hi, > > On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: > > On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires > > wrote: > >> On Dec 05 2016 or thereabouts, Rob Herring wrote: > >>> On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi, On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: > On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires > wrote: >> On Dec 05 2016 or thereabouts, Rob Herring wrote: >>> On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: >>> > Hi

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi, On Tue, Dec 6, 2016 at 6:56 AM, Rob Herring wrote: > On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires > wrote: >> On Dec 05 2016 or thereabouts, Rob Herring wrote: >>> On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: >>> > Hi Benjamin and Rob, >>> > >>> > On Thu, Dec 01, 2016

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires wrote: > On Dec 05 2016 or thereabouts, Rob Herring wrote: >> On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: >> > Hi Benjamin and Rob, >> > >> > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Tue, Dec 6, 2016 at 2:48 AM, Benjamin Tissoires wrote: > On Dec 05 2016 or thereabouts, Rob Herring wrote: >> On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: >> > Hi Benjamin and Rob, >> > >> > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: >> > > On Nov 30

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Dec 05 2016 or thereabouts, Rob Herring wrote: > On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: > > Hi Benjamin and Rob, > > > > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > > > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > > > From: Caesar Wang

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Dec 05 2016 or thereabouts, Rob Herring wrote: > On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: > > Hi Benjamin and Rob, > > > > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > > > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > > > From: Caesar Wang

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Mon, Dec 05, 2016 at 05:59:08PM -0600, Rob Herring wrote: > On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: > > Hi Benjamin and Rob, > > > > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > > > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > > > From:

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Mon, Dec 05, 2016 at 05:59:08PM -0600, Rob Herring wrote: > On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: > > Hi Benjamin and Rob, > > > > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > > > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > > > From:

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: > Hi Benjamin and Rob, > > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > > From: Caesar Wang > > > > > > Add a compatible string

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Thu, Dec 01, 2016 at 09:24:50AM -0800, Brian Norris wrote: > Hi Benjamin and Rob, > > On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > > From: Caesar Wang > > > > > > Add a compatible string and regulator property

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi Rob, On Mon, Dec 05, 2016 at 05:42:48PM -0600, Rob Herring wrote: > On Wed, Nov 30, 2016 at 05:21:27PM -0800, Brian Norris wrote: > > From: Caesar Wang > > > > Add a compatible string and regulator property for Wacom W9103 > > digitizer. Its VDD supply may need to be

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi Rob, On Mon, Dec 05, 2016 at 05:42:48PM -0600, Rob Herring wrote: > On Wed, Nov 30, 2016 at 05:21:27PM -0800, Brian Norris wrote: > > From: Caesar Wang > > > > Add a compatible string and regulator property for Wacom W9103 > > digitizer. Its VDD supply may need to be enabled before using it.

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Wed, Nov 30, 2016 at 05:21:27PM -0800, Brian Norris wrote: > From: Caesar Wang > > Add a compatible string and regulator property for Wacom W9103 > digitizer. Its VDD supply may need to be enabled before using it. > > Signed-off-by: Caesar Wang >

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Wed, Nov 30, 2016 at 05:21:27PM -0800, Brian Norris wrote: > From: Caesar Wang > > Add a compatible string and regulator property for Wacom W9103 > digitizer. Its VDD supply may need to be enabled before using it. > > Signed-off-by: Caesar Wang > Cc: Rob Herring > Cc: Jiri Kosina > Cc:

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi Benjamin and Rob, On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > From: Caesar Wang > > > > Add a compatible string and regulator property for Wacom W9103 > > digitizer. Its VDD supply may need

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

Hi Benjamin and Rob, On Thu, Dec 01, 2016 at 03:34:34PM +0100, Benjamin Tissoires wrote: > On Nov 30 2016 or thereabouts, Brian Norris wrote: > > From: Caesar Wang > > > > Add a compatible string and regulator property for Wacom W9103 > > digitizer. Its VDD supply may need to be enabled before

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Nov 30 2016 or thereabouts, Brian Norris wrote: > From: Caesar Wang > > Add a compatible string and regulator property for Wacom W9103 > digitizer. Its VDD supply may need to be enabled before using it. > > Signed-off-by: Caesar Wang > Cc: Rob

Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

On Nov 30 2016 or thereabouts, Brian Norris wrote: > From: Caesar Wang > > Add a compatible string and regulator property for Wacom W9103 > digitizer. Its VDD supply may need to be enabled before using it. > > Signed-off-by: Caesar Wang > Cc: Rob Herring > Cc: Jiri Kosina > Cc:

[PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

From: Caesar Wang Add a compatible string and regulator property for Wacom W9103 digitizer. Its VDD supply may need to be enabled before using it. Signed-off-by: Caesar Wang Cc: Rob Herring Cc: Jiri Kosina Cc:

[PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

From: Caesar Wang Add a compatible string and regulator property for Wacom W9103 digitizer. Its VDD supply may need to be enabled before using it. Signed-off-by: Caesar Wang Cc: Rob Herring Cc: Jiri Kosina Cc: linux-in...@vger.kernel.org Signed-off-by: Brian Norris --- v1 was a few months