RE: [PATCH v2 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-15 Thread David Laight
From: Xander Huff > Put #define comments into a single line. Breaks the 80 char limit. I suspect the definitions could be made to fit by judicial editing. But that probably requires knowing exactly what the comments mean. David > Signed-off-by: Xander Huff > --- >

Re: [PATCH v2 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-15 Thread Nicolas Ferre
Le 14/01/2015 23:20, Xander Huff a écrit : > Put #define comments into a single line. It seems that correction is not done for all the entries modified: @ 0x0100 to 0x01b0 Can you please consider correcting this? Thanks, bye. > Signed-off-by: Xander Huff > --- >

RE: [PATCH v2 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-15 Thread David Laight
From: Xander Huff Put #define comments into a single line. Breaks the 80 char limit. I suspect the definitions could be made to fit by judicial editing. But that probably requires knowing exactly what the comments mean. David Signed-off-by: Xander Huff xander.h...@ni.com ---

Re: [PATCH v2 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-15 Thread Nicolas Ferre
Le 14/01/2015 23:20, Xander Huff a écrit : Put #define comments into a single line. It seems that correction is not done for all the entries modified: @ 0x0100 to 0x01b0 Can you please consider correcting this? Thanks, bye. Signed-off-by: Xander Huff xander.h...@ni.com ---

[PATCH v2 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-14 Thread Xander Huff
Put #define comments into a single line. Signed-off-by: Xander Huff --- drivers/net/ethernet/cadence/macb.h | 107 +--- 1 file changed, 26 insertions(+), 81 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h

[PATCH v2 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-14 Thread Xander Huff
Put #define comments into a single line. Signed-off-by: Xander Huff xander.h...@ni.com --- drivers/net/ethernet/cadence/macb.h | 107 +--- 1 file changed, 26 insertions(+), 81 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.h