Re: [PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-07-03 Thread Parthiban Nallathambi
Hello Peter, Thanks for your comments. Will send v3 with comments fixed. On 06/30/2018 11:51 AM, Peter Meerwald-Stadler wrote: Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function comments below a

Re: [PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-07-03 Thread Parthiban Nallathambi
Hello Peter, Thanks for your comments. Will send v3 with comments fixed. On 06/30/2018 11:51 AM, Peter Meerwald-Stadler wrote: Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function comments below a

Re: [PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-06-30 Thread Peter Meerwald-Stadler
> Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function comments below a lot of effort is in getting a timestamp; is it worth it for ALS measurement? also the implementation is quite involved, what

Re: [PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-06-30 Thread Peter Meerwald-Stadler
> Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function comments below a lot of effort is in getting a timestamp; is it worth it for ALS measurement? also the implementation is quite involved, what

Re: [PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-06-29 Thread kbuild test robot
Hi Parthiban, Thank you for the patch! Yet something to improve: [auto build test ERROR on iio/togreg] [also build test ERROR on v4.18-rc2 next-20180629] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-06-29 Thread kbuild test robot
Hi Parthiban, Thank you for the patch! Yet something to improve: [auto build test ERROR on iio/togreg] [also build test ERROR on v4.18-rc2 next-20180629] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-06-29 Thread Parthiban Nallathambi
Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by: Parthiban Nallathambi --- Changelog since v1: 1. Fixed 0-day warning on le16_to_cpu usage 2. Persistence value is directly mapped to

[PATCH v2 1/2] iio: light: Add support for vishay vcnl4035

2018-06-29 Thread Parthiban Nallathambi
Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by: Parthiban Nallathambi --- Changelog since v1: 1. Fixed 0-day warning on le16_to_cpu usage 2. Persistence value is directly mapped to