Re: [PATCH v2 1/2] mm: add GFP mask param to strndup_user

2020-08-22 Thread Pascal Bouchareine
Thanks for taking a look! On Fri, Aug 21, 2020 at 8:51 PM Andrew Morton wrote: > Why change all existing callsites so that one callsite can pass in a > different gfp_t? My initial thought was to change strndup_user to use GFP_KERNEL_ACCOUNT (or GFP_USER | __GFP_ACCOUNT ?) unconditionally.

Re: [PATCH v2 1/2] mm: add GFP mask param to strndup_user

2020-08-21 Thread Andrew Morton
On Fri, 21 Aug 2020 20:28:26 -0700 Pascal Bouchareine wrote: > Let caller specify allocation. > Preserve existing calls with GFP_USER. > > 21 files changed, 65 insertions(+), 43 deletions(-) Why change all existing callsites so that one callsite can pass in a different gfp_t? > diff --git

[PATCH v2 1/2] mm: add GFP mask param to strndup_user

2020-08-21 Thread Pascal Bouchareine
Let caller specify allocation. Preserve existing calls with GFP_USER. Signed-off-by: Pascal Bouchareine --- Updating patch 1/ and 2/ to address comments drivers/dma-buf/dma-buf.c | 2 +- drivers/gpu/drm/i915/i915_debugfs_params.c | 2 +- drivers/gpu/drm/vc4/vc4_bo.c