Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Kees Cook
On Wed, Nov 4, 2015 at 2:10 PM, Eric W. Biederman wrote: > Daniel Cashman writes: > >> On 11/3/15 5:31 PM, Andrew Morton wrote: >>> On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. >>> Biederman) wrote: >>> Andrew Morton writes: > On Tue, 3 Nov 2015 10:10:03

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Eric W. Biederman
Daniel Cashman writes: > On 11/3/15 5:31 PM, Andrew Morton wrote: >> On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. Biederman) >> wrote: >> >>> Andrew Morton writes: >>> On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman wrote: > ASLR currently only uses

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Andrew Morton
On Wed, 4 Nov 2015 11:31:25 -0800 Daniel Cashman wrote: > As for the > clarification itself, where would you like it? I could include a cover > letter for this patch-set, elaborate more in the commit message itself, > add more to the Kconfig help description, or some combination of the above.

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Daniel Cashman
On 11/4/15 11:21 AM, Eric W. Biederman wrote: > Michal Hocko writes: > >> On Tue 03-11-15 10:10:03, Daniel Cashman wrote: >> [...] >>> +This value can be changed after boot using the >>> +/proc/sys/kernel/mmap_rnd_bits tunable >> >> Why is this not sitting in /proc/sys/vm/ where we already have

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Daniel Cashman
On 11/3/15 5:31 PM, Andrew Morton wrote: > On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. Biederman) > wrote: > >> Andrew Morton writes: >> >>> On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman >>> wrote: >>> ASLR currently only uses 8 bits to generate the random

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Eric W. Biederman
Michal Hocko writes: > On Tue 03-11-15 10:10:03, Daniel Cashman wrote: > [...] >> +This value can be changed after boot using the >> +/proc/sys/kernel/mmap_rnd_bits tunable > > Why is this not sitting in /proc/sys/vm/ where we already have > mmap_min_addr. These two sound like they should sit

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Michal Hocko
On Tue 03-11-15 10:10:03, Daniel Cashman wrote: [...] > +This value can be changed after boot using the > +/proc/sys/kernel/mmap_rnd_bits tunable Why is this not sitting in /proc/sys/vm/ where we already have mmap_min_addr. These two sound like they should sit together, no? -- Michal Hocko SUSE

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Kees Cook
On Wed, Nov 4, 2015 at 2:10 PM, Eric W. Biederman wrote: > Daniel Cashman writes: > >> On 11/3/15 5:31 PM, Andrew Morton wrote: >>> On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. >>> Biederman) wrote: >>> Andrew Morton

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Andrew Morton
On Wed, 4 Nov 2015 11:31:25 -0800 Daniel Cashman wrote: > As for the > clarification itself, where would you like it? I could include a cover > letter for this patch-set, elaborate more in the commit message itself, > add more to the Kconfig help description, or some

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Eric W. Biederman
Daniel Cashman writes: > On 11/3/15 5:31 PM, Andrew Morton wrote: >> On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. Biederman) >> wrote: >> >>> Andrew Morton writes: >>> On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Daniel Cashman
On 11/3/15 5:31 PM, Andrew Morton wrote: > On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. Biederman) > wrote: > >> Andrew Morton writes: >> >>> On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman >>> wrote: >>> ASLR

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Daniel Cashman
On 11/4/15 11:21 AM, Eric W. Biederman wrote: > Michal Hocko writes: > >> On Tue 03-11-15 10:10:03, Daniel Cashman wrote: >> [...] >>> +This value can be changed after boot using the >>> +/proc/sys/kernel/mmap_rnd_bits tunable >> >> Why is this not sitting in /proc/sys/vm/

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Eric W. Biederman
Michal Hocko writes: > On Tue 03-11-15 10:10:03, Daniel Cashman wrote: > [...] >> +This value can be changed after boot using the >> +/proc/sys/kernel/mmap_rnd_bits tunable > > Why is this not sitting in /proc/sys/vm/ where we already have > mmap_min_addr. These two sound like

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-04 Thread Michal Hocko
On Tue 03-11-15 10:10:03, Daniel Cashman wrote: [...] > +This value can be changed after boot using the > +/proc/sys/kernel/mmap_rnd_bits tunable Why is this not sitting in /proc/sys/vm/ where we already have mmap_min_addr. These two sound like they should sit together, no? -- Michal Hocko SUSE

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Andrew Morton
On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. Biederman) wrote: > Andrew Morton writes: > > > On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman > > wrote: > > > >> ASLR currently only uses 8 bits to generate the random offset for the > >> mmap base address on 32 bit

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Eric W. Biederman
Andrew Morton writes: > On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman > wrote: > >> ASLR currently only uses 8 bits to generate the random offset for the >> mmap base address on 32 bit architectures. This value was chosen to >> prevent a poorly chosen value from dividing the address space

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Andrew Morton
On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman wrote: > ASLR currently only uses 8 bits to generate the random offset for the > mmap base address on 32 bit architectures. This value was chosen to > prevent a poorly chosen value from dividing the address space in such > a way as to prevent

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Kees Cook
On Tue, Nov 3, 2015 at 10:10 AM, Daniel Cashman wrote: > From: dcashman > > ASLR currently only uses 8 bits to generate the random offset for the > mmap base address on 32 bit architectures. This value was chosen to > prevent a poorly chosen value from dividing the address space in such > a way

[PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Daniel Cashman
From: dcashman ASLR currently only uses 8 bits to generate the random offset for the mmap base address on 32 bit architectures. This value was chosen to prevent a poorly chosen value from dividing the address space in such a way as to prevent large allocations. This may not be an issue on all

[PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Daniel Cashman
From: dcashman ASLR currently only uses 8 bits to generate the random offset for the mmap base address on 32 bit architectures. This value was chosen to prevent a poorly chosen value from dividing the address space in such a way as to prevent large allocations. This may not

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Kees Cook
On Tue, Nov 3, 2015 at 10:10 AM, Daniel Cashman wrote: > From: dcashman > > ASLR currently only uses 8 bits to generate the random offset for the > mmap base address on 32 bit architectures. This value was chosen to > prevent a poorly chosen value from

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Andrew Morton
On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman wrote: > ASLR currently only uses 8 bits to generate the random offset for the > mmap base address on 32 bit architectures. This value was chosen to > prevent a poorly chosen value from dividing the address space in such > a

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Andrew Morton
On Tue, 03 Nov 2015 18:40:31 -0600 ebied...@xmission.com (Eric W. Biederman) wrote: > Andrew Morton writes: > > > On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman > > wrote: > > > >> ASLR currently only uses 8 bits to generate the random

Re: [PATCH v2 1/2] mm: mmap: Add new /proc tunable for mmap_base ASLR.

2015-11-03 Thread Eric W. Biederman
Andrew Morton writes: > On Tue, 3 Nov 2015 10:10:03 -0800 Daniel Cashman > wrote: > >> ASLR currently only uses 8 bits to generate the random offset for the >> mmap base address on 32 bit architectures. This value was chosen to >> prevent a