Re: [PATCH v2 1/2] mtd: nand: Error out if cmd_ctrl() is missing

2016-07-20 Thread Andrey Smirnov
On Tue, Jul 19, 2016 at 11:44 PM, Boris Brezillon wrote: > On Tue, 19 Jul 2016 22:33:57 -0700 > Andrey Smirnov wrote: > >> If no user specified chip->select_chip() function is provided, code in >> nand_base.c will automatically set this hook to nand_select_chip(), >> which in turn depends on chip

Re: [PATCH v2 1/2] mtd: nand: Error out if cmd_ctrl() is missing

2016-07-19 Thread Boris Brezillon
On Tue, 19 Jul 2016 22:33:57 -0700 Andrey Smirnov wrote: > If no user specified chip->select_chip() function is provided, code in > nand_base.c will automatically set this hook to nand_select_chip(), > which in turn depends on chip->cmd_ctrl() hook being valid. Not > providing both of those funct

[PATCH v2 1/2] mtd: nand: Error out if cmd_ctrl() is missing

2016-07-19 Thread Andrey Smirnov
If no user specified chip->select_chip() function is provided, code in nand_base.c will automatically set this hook to nand_select_chip(), which in turn depends on chip->cmd_ctrl() hook being valid. Not providing both of those functions in NAND controller driver (for example by mistake) will result