Re: [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

On Tue, Jan 16, 2018 at 05:49:54PM +0100, Christoph Hellwig wrote: > > + trace_seq_printf(p, "slba=%llu, length=%u, control=0x%x, dsmgmt=%u, > > reftag=%u", > > Overly long line. > > > +(unsigned long long)le64_to_cpu(rw.slba), > > u64 now always is an unsigned long long,

Re: [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

On Tue, Jan 16, 2018 at 05:49:54PM +0100, Christoph Hellwig wrote: > > + trace_seq_printf(p, "slba=%llu, length=%u, control=0x%x, dsmgmt=%u, > > reftag=%u", > > Overly long line. > > > +(unsigned long long)le64_to_cpu(rw.slba), > > u64 now always is an unsigned long long,

Re: [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

> + trace_seq_printf(p, "slba=%llu, length=%u, control=0x%x, dsmgmt=%u, > reftag=%u", Overly long line. > + (unsigned long long)le64_to_cpu(rw.slba), u64 now always is an unsigned long long, no need for the cast. > + le16_to_cpu(rw.length),

Re: [PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

> + trace_seq_printf(p, "slba=%llu, length=%u, control=0x%x, dsmgmt=%u, > reftag=%u", Overly long line. > + (unsigned long long)le64_to_cpu(rw.slba), u64 now always is an unsigned long long, no need for the cast. > + le16_to_cpu(rw.length),

[PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

Signed-off-by: Johannes Thumshirn --- Changes to v1: * Fix typo (Hannes) * move include/trace/events/nvme.h -> drivers/nvme/host/trace.h (Christoph) --- drivers/nvme/host/core.c | 69 +++ drivers/nvme/host/trace.h | 69

[PATCH v2 1/2] nvme: add tracepoint for nvme_setup_cmd

Signed-off-by: Johannes Thumshirn --- Changes to v1: * Fix typo (Hannes) * move include/trace/events/nvme.h -> drivers/nvme/host/trace.h (Christoph) --- drivers/nvme/host/core.c | 69 +++ drivers/nvme/host/trace.h | 69