Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-06 Thread Murali Karicheri
On 01/06/2015 02:50 PM, Will Deacon wrote: On Fri, Jan 02, 2015 at 10:33:53PM +, Murali Karicheri wrote: On 01/02/2015 03:45 PM, Rob Herring wrote: On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicheri wrote: On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24, 2014 at 4:11 PM,

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-06 Thread Will Deacon
On Fri, Jan 02, 2015 at 10:33:53PM +, Murali Karicheri wrote: > On 01/02/2015 03:45 PM, Rob Herring wrote: > > On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicheri > > wrote: > >> On 12/26/2014 02:33 PM, Rob Herring wrote: > >>> On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicheri > +

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-06 Thread Will Deacon
On Fri, Jan 02, 2015 at 10:33:53PM +, Murali Karicheri wrote: On 01/02/2015 03:45 PM, Rob Herring wrote: On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicherim-kariche...@ti.com wrote: On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24, 2014 at 4:11 PM, Murali

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-06 Thread Murali Karicheri
On 01/06/2015 02:50 PM, Will Deacon wrote: On Fri, Jan 02, 2015 at 10:33:53PM +, Murali Karicheri wrote: On 01/02/2015 03:45 PM, Rob Herring wrote: On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicherim-kariche...@ti.com wrote: On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24,

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-05 Thread Murali Karicheri
On 01/05/2015 05:26 PM, Arnd Bergmann wrote: On Monday 05 January 2015 15:06:57 Murali Karicheri wrote: On 01/03/2015 04:37 PM, Arnd Bergmann wrote: Yes, but we also need to pass a PCI device specific identifier along with the root bus node, because some iommu drivers take the PCI

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-05 Thread Arnd Bergmann
On Monday 05 January 2015 15:06:57 Murali Karicheri wrote: > On 01/03/2015 04:37 PM, Arnd Bergmann wrote: > > Yes, but we also need to pass a PCI device specific identifier along > > with the root bus node, because some iommu drivers take the PCI > > bus/device/function number into account for

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-05 Thread Murali Karicheri
On 01/03/2015 04:37 PM, Arnd Bergmann wrote: On Friday 02 January 2015 17:33:53 Murali Karicheri wrote: I have no experience with IOMMU and may not offer much help here as I originally wrote above. Will Deacon has added this API and probably able to offer some help in this discussion. Will

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-05 Thread Arnd Bergmann
On Monday 05 January 2015 15:06:57 Murali Karicheri wrote: On 01/03/2015 04:37 PM, Arnd Bergmann wrote: Yes, but we also need to pass a PCI device specific identifier along with the root bus node, because some iommu drivers take the PCI bus/device/function number into account for creating

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-05 Thread Murali Karicheri
On 01/05/2015 05:26 PM, Arnd Bergmann wrote: On Monday 05 January 2015 15:06:57 Murali Karicheri wrote: On 01/03/2015 04:37 PM, Arnd Bergmann wrote: Yes, but we also need to pass a PCI device specific identifier along with the root bus node, because some iommu drivers take the PCI

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-05 Thread Murali Karicheri
On 01/03/2015 04:37 PM, Arnd Bergmann wrote: On Friday 02 January 2015 17:33:53 Murali Karicheri wrote: I have no experience with IOMMU and may not offer much help here as I originally wrote above. Will Deacon has added this API and probably able to offer some help in this discussion. Will

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-03 Thread Arnd Bergmann
On Friday 02 January 2015 17:33:53 Murali Karicheri wrote: > > I have no experience with IOMMU and may not offer much help here as I > originally wrote above. Will Deacon has added this API and probably able > to offer some help in this discussion. > > Will Deacon, > > Any comment? It's

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-03 Thread Arnd Bergmann
On Friday 02 January 2015 17:33:53 Murali Karicheri wrote: I have no experience with IOMMU and may not offer much help here as I originally wrote above. Will Deacon has added this API and probably able to offer some help in this discussion. Will Deacon, Any comment? It's complicated

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Murali Karicheri
On 01/02/2015 03:45 PM, Rob Herring wrote: On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicheri wrote: Rob, See my response below. Arnd and Will, please review this as well. On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicheri wrote: Add

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Murali Karicheri
On 01/02/2015 03:57 PM, Arnd Bergmann wrote: On Friday 02 January 2015 12:20:53 Murali Karicheri wrote: Initially I had the same idea to re-use the existing function of_dma_configure() for this. I wanted to defer this until we have an agreement on the changes required for the subject

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Arnd Bergmann
On Friday 02 January 2015 12:20:53 Murali Karicheri wrote: > Initially I had the same idea to re-use the existing function > of_dma_configure() for this. I wanted to defer this until we have an > agreement on the changes required for the subject functionality. My > quick review of the code

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Rob Herring
On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicheri wrote: > Rob, > > See my response below. Arnd and Will, please review this as well. > > On 12/26/2014 02:33 PM, Rob Herring wrote: >> >> On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicheri >> wrote: >>> >>> Add of_pci_dma_configure() to allow

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Murali Karicheri
Rob, See my response below. Arnd and Will, please review this as well. On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicheri wrote: Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the configuration from DT of

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Murali Karicheri
On 01/02/2015 03:45 PM, Rob Herring wrote: On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicherim-kariche...@ti.com wrote: Rob, See my response below. Arnd and Will, please review this as well. On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24, 2014 at 4:11 PM, Murali

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Arnd Bergmann
On Friday 02 January 2015 12:20:53 Murali Karicheri wrote: Initially I had the same idea to re-use the existing function of_dma_configure() for this. I wanted to defer this until we have an agreement on the changes required for the subject functionality. My quick review of the code

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Rob Herring
On Fri, Jan 2, 2015 at 11:20 AM, Murali Karicheri m-kariche...@ti.com wrote: Rob, See my response below. Arnd and Will, please review this as well. On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicherim-kariche...@ti.com wrote: Add

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Murali Karicheri
Rob, See my response below. Arnd and Will, please review this as well. On 12/26/2014 02:33 PM, Rob Herring wrote: On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicherim-kariche...@ti.com wrote: Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2015-01-02 Thread Murali Karicheri
On 01/02/2015 03:57 PM, Arnd Bergmann wrote: On Friday 02 January 2015 12:20:53 Murali Karicheri wrote: Initially I had the same idea to re-use the existing function of_dma_configure() for this. I wanted to defer this until we have an agreement on the changes required for the subject

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2014-12-26 Thread Rob Herring
On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicheri wrote: > Add of_pci_dma_configure() to allow updating the dma configuration > of the pci device using the configuration from DT of the parent of > the root bridge device. > > Signed-off-by: Murali Karicheri > --- > drivers/of/of_pci.c| 73

Re: [PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2014-12-26 Thread Rob Herring
On Wed, Dec 24, 2014 at 4:11 PM, Murali Karicheri m-kariche...@ti.com wrote: Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the configuration from DT of the parent of the root bridge device. Signed-off-by: Murali Karicheri m-kariche...@ti.com ---

[PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2014-12-24 Thread Murali Karicheri
Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the configuration from DT of the parent of the root bridge device. Signed-off-by: Murali Karicheri --- drivers/of/of_pci.c| 73

[PATCH v2 1/2] of/pci: add of_pci_dma_configure() update dma configuration

2014-12-24 Thread Murali Karicheri
Add of_pci_dma_configure() to allow updating the dma configuration of the pci device using the configuration from DT of the parent of the root bridge device. Signed-off-by: Murali Karicheri m-kariche...@ti.com --- drivers/of/of_pci.c| 73