Re: [PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-14 Thread Linus Walleij
On Thu, Mar 2, 2017 at 9:30 AM, Kever Yang wrote: >> Signed-off-by: david.wu > > Better to use "David Wu" for full name, you can correct this in your > gitconfig file. Yeah please do that, I fix it up manually every time. Yours, Linus

Re: [PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-14 Thread Linus Walleij
On Thu, Mar 2, 2017 at 9:30 AM, Kever Yang wrote: >> Signed-off-by: david.wu > > Better to use "David Wu" for full name, you can correct this in your > gitconfig file. Yeah please do that, I fix it up manually every time. Yours, Linus Walleij

Re: [PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-14 Thread Linus Walleij
On Thu, Mar 2, 2017 at 8:11 AM, David Wu wrote: > From: "david.wu" > > To prevent external signal crosstalk, some pins need to > enable input schmitt, like i2c pins, 32k-input pin and so on. > > Signed-off-by: david.wu

Re: [PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-14 Thread Linus Walleij
On Thu, Mar 2, 2017 at 8:11 AM, David Wu wrote: > From: "david.wu" > > To prevent external signal crosstalk, some pins need to > enable input schmitt, like i2c pins, 32k-input pin and so on. > > Signed-off-by: david.wu > --- > changes in v2: > - check the return value (Heiko) Patch applied.

Re: [PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-02 Thread Kever Yang
Hi David, On 03/02/2017 03:11 PM, David Wu wrote: From: "david.wu" You do not need to add this when you send mail for yourself, it's need when you send mail for others. To prevent external signal crosstalk, some pins need to enable input schmitt, like i2c pins,

Re: [PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-02 Thread Kever Yang
Hi David, On 03/02/2017 03:11 PM, David Wu wrote: From: "david.wu" You do not need to add this when you send mail for yourself, it's need when you send mail for others. To prevent external signal crosstalk, some pins need to enable input schmitt, like i2c pins, 32k-input pin and so on.

[PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-01 Thread David Wu
From: "david.wu" To prevent external signal crosstalk, some pins need to enable input schmitt, like i2c pins, 32k-input pin and so on. Signed-off-by: david.wu --- changes in v2: - check the return value (Heiko)

[PATCH v2 1/2] pinctrl: rockchip：Add input schmitt support

2017-03-01 Thread David Wu
From: "david.wu" To prevent external signal crosstalk, some pins need to enable input schmitt, like i2c pins, 32k-input pin and so on. Signed-off-by: david.wu --- changes in v2: - check the return value (Heiko) drivers/pinctrl/pinctrl-rockchip.c | 73 ++