Re: [PATCH v2 1/2] pwm: kona: Fix incorrect enable, config, and disable procedures

2014-12-16 Thread Jonathan Richardson
On 14-12-14 11:18 PM, Tim Kryger wrote: > On Wed, Dec 10, 2014 at 5:07 PM, Jonathan Richardson > wrote: > >> If config is called when the pwm is disabled and there is nothing to do, >> the while loop to calculate duty cycle and period doesn't need to be >> done. The function now just

Re: [PATCH v2 1/2] pwm: kona: Fix incorrect enable, config, and disable procedures

2014-12-14 Thread Tim Kryger
On Wed, Dec 10, 2014 at 5:07 PM, Jonathan Richardson wrote: > If config is called when the pwm is disabled and there is nothing to do, > the while loop to calculate duty cycle and period doesn't need to be > done. The function now just returns if the pwm state is disabled. It doesn't

[PATCH v2 1/2] pwm: kona: Fix incorrect enable, config, and disable procedures

2014-12-10 Thread Jonathan Richardson
The config procedure doesn't follow the spec which periodically results in failing to enable the output signal. This happens one in ten or twenty attempts. Following the spec and adding a 400ns delay in the appropriate locations resolves this problem. It also ensures that the si