On Tue, Apr 15, 2014 at 11:14:13PM +0800, Axel Lin wrote:
> commit 60e8c1e34d3a
> "regulator: pbias: Convert to use regmap helper functions"
> might also required for 3.15.
> The reason is this commit implements .list_voltage and the mmc core calls
> regulator_list_voltage() in
On Tue, Apr 15, 2014 at 11:14:13PM +0800, Axel Lin wrote:
commit 60e8c1e34d3a
regulator: pbias: Convert to use regmap helper functions
might also required for 3.15.
The reason is this commit implements .list_voltage and the mmc core calls
regulator_list_voltage() in
2014-04-15 5:16 GMT+08:00 Mark Brown :
> On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
>> The is_enabled implementation is wrong in some cases:
>> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
>> However, pbias_regulator_enable() only sets BIT(27) | BIT(26)
2014-04-15 5:16 GMT+08:00 Mark Brown broo...@kernel.org:
On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27) |
On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
> The is_enabled implementation is wrong in some cases:
> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
> So is_enabled callback will always
On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
So is_enabled callback will always return
On Wed, Apr 09, 2014 at 05:50:42PM +0800, Axel Lin wrote:
> I just found Chris sent a pull request for 3.15-rc1.
> So I'll resend this serial to Mark after 3.15-rc1 is out.
I still have it, I'll go through after -rc1. I was also kind of hoping
for some review from people working on the driver
On Wed, Apr 09, 2014 at 05:50:42PM +0800, Axel Lin wrote:
I just found Chris sent a pull request for 3.15-rc1.
So I'll resend this serial to Mark after 3.15-rc1 is out.
I still have it, I'll go through after -rc1. I was also kind of hoping
for some review from people working on the driver but
2014-04-02 8:26 GMT+08:00 Axel Lin :
> 2014-03-08 11:55 GMT+08:00 Axel Lin :
>> The is_enabled implementation is wrong in some cases:
>> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
>> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
>> So is_enabled
2014-04-02 8:26 GMT+08:00 Axel Lin axel@ingics.com:
2014-03-08 11:55 GMT+08:00 Axel Lin axel@ingics.com:
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27) |
2014-03-08 11:55 GMT+08:00 Axel Lin :
> The is_enabled implementation is wrong in some cases:
> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
> So is_enabled callback will always return false in this
2014-03-08 11:55 GMT+08:00 Axel Lin axel@ingics.com:
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
So is_enabled callback will always return
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
So is_enabled callback will always return false in this case.
Fix the logic to compare the register value
The is_enabled implementation is wrong in some cases:
e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
So is_enabled callback will always return false in this case.
Fix the logic to compare the register value
14 matches
Mail list logo
