Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

2016-09-06 0:26 GMT+02:00 Alexandre Belloni : > Hi > > On 01/09/2016 at 00:58:59 +0200, Gabriele Mazzotta wrote : >> static int cmos_resume(struct device *dev) >> { >> struct cmos_rtc *cmos = dev_get_drvdata(dev); >> unsigned char tmp; >> +

Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

2016-09-06 0:26 GMT+02:00 Alexandre Belloni : > Hi > > On 01/09/2016 at 00:58:59 +0200, Gabriele Mazzotta wrote : >> static int cmos_resume(struct device *dev) >> { >> struct cmos_rtc *cmos = dev_get_drvdata(dev); >> unsigned char tmp; >> + bool is_wkalrm_expired; >> >> if

Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

Hi On 01/09/2016 at 00:58:59 +0200, Gabriele Mazzotta wrote : > static int cmos_resume(struct device *dev) > { > struct cmos_rtc *cmos = dev_get_drvdata(dev); > unsigned char tmp; > + bool is_wkalrm_expired; > > if (cmos->enabled_wake) { > if

Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

Hi On 01/09/2016 at 00:58:59 +0200, Gabriele Mazzotta wrote : > static int cmos_resume(struct device *dev) > { > struct cmos_rtc *cmos = dev_get_drvdata(dev); > unsigned char tmp; > + bool is_wkalrm_expired; > > if (cmos->enabled_wake) { > if

Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

On 01/09/2016 00:58, Gabriele Mazzotta wrote: > Some BIOSes, such as the one of the Dell XPS13 9333, wake the system > when an alarm goes off without informing the OS. If any of the A clarification on this first sentence. I was looking at the ACPI specification [1] and it seems that there are two

Re: [PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

On 01/09/2016 00:58, Gabriele Mazzotta wrote: > Some BIOSes, such as the one of the Dell XPS13 9333, wake the system > when an alarm goes off without informing the OS. If any of the A clarification on this first sentence. I was looking at the ACPI specification [1] and it seems that there are two

[PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

Some BIOSes, such as the one of the Dell XPS13 9333, wake the system when an alarm goes off without informing the OS. If any of the RTC_IRQMASK bits is set when this happens and hpet is enabled, the alarm is not automatically cleared at resume. As consequence, the user must manually clear the

[PATCH v2 1/2] rtc-cmos: Ensure no expired alarm is left enabled after resume

Some BIOSes, such as the one of the Dell XPS13 9333, wake the system when an alarm goes off without informing the OS. If any of the RTC_IRQMASK bits is set when this happens and hpet is enabled, the alarm is not automatically cleared at resume. As consequence, the user must manually clear the