Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-10-16 Thread David Gstir
Hi! > On 03.08.2018, at 20:28, Mimi Zohar wrote: > > If they have symmetric key support, there would be no need for > the > symmetric key ever to leave the device in the clear. The device > would unseal/decrypt data, such as an encrypted key. > > The "symmetric" key

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-10-16 Thread David Gstir
Hi! > On 03.08.2018, at 20:28, Mimi Zohar wrote: > > If they have symmetric key support, there would be no need for > the > symmetric key ever to leave the device in the clear. The device > would unseal/decrypt data, such as an encrypted key. > > The "symmetric" key

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Fri, 2018-08-03 at 08:48 -0700, James Bottomley wrote: > On Fri, 2018-08-03 at 10:45 -0400, Mimi Zohar wrote: > > On Fri, 2018-08-03 at 07:23 -0700, James Bottomley wrote: > > > On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > > > > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote:

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Fri, 2018-08-03 at 08:48 -0700, James Bottomley wrote: > On Fri, 2018-08-03 at 10:45 -0400, Mimi Zohar wrote: > > On Fri, 2018-08-03 at 07:23 -0700, James Bottomley wrote: > > > On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > > > > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote:

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread James Bottomley
On Fri, 2018-08-03 at 10:45 -0400, Mimi Zohar wrote: > On Fri, 2018-08-03 at 07:23 -0700, James Bottomley wrote: > > On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > > > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > > > > Udit Agarwal wrote: > > > > > > > > > +== > > >

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread James Bottomley
On Fri, 2018-08-03 at 10:45 -0400, Mimi Zohar wrote: > On Fri, 2018-08-03 at 07:23 -0700, James Bottomley wrote: > > On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > > > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > > > > Udit Agarwal wrote: > > > > > > > > > +== > > >

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Fri, 2018-08-03 at 15:55 +0100, David Howells wrote: > Mimi Zohar wrote: > > > "trusted" keys are currently being used to decrypt other keys (eg. > > encrypted, ecryptfs, ...). > > Can it decrypt both symmetric and asymmetric keys? Yes, the "trusted" key is returned to the caller and is

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Fri, 2018-08-03 at 15:55 +0100, David Howells wrote: > Mimi Zohar wrote: > > > "trusted" keys are currently being used to decrypt other keys (eg. > > encrypted, ecryptfs, ...). > > Can it decrypt both symmetric and asymmetric keys? Yes, the "trusted" key is returned to the caller and is

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread David Howells
Mimi Zohar wrote: > "trusted" keys are currently being used to decrypt other keys (eg. > encrypted, ecryptfs, ...). Can it decrypt both symmetric and asymmetric keys? David

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread David Howells
Mimi Zohar wrote: > "trusted" keys are currently being used to decrypt other keys (eg. > encrypted, ecryptfs, ...). Can it decrypt both symmetric and asymmetric keys? David

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Fri, 2018-08-03 at 07:23 -0700, James Bottomley wrote: > On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > > > Udit Agarwal wrote: > > > > > > > +== > > > > +Secure Key > > > > +== > > > > + > > > > +Secure key

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Fri, 2018-08-03 at 07:23 -0700, James Bottomley wrote: > On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > > > Udit Agarwal wrote: > > > > > > > +== > > > > +Secure Key > > > > +== > > > > + > > > > +Secure key

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread James Bottomley
On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > > Udit Agarwal wrote: > > > > > +== > > > +Secure Key > > > +== > > > + > > > +Secure key is the new type added to kernel key ring service. > > > +Secure key is a

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread James Bottomley
On Fri, 2018-08-03 at 07:58 -0400, Mimi Zohar wrote: > On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > > Udit Agarwal wrote: > > > > > +== > > > +Secure Key > > > +== > > > + > > > +Secure key is the new type added to kernel key ring service. > > > +Secure key is a

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > Udit Agarwal wrote: > > > +== > > +Secure Key > > +== > > + > > +Secure key is the new type added to kernel key ring service. > > +Secure key is a symmetric type key of minimum length 32 bytes > > +and with maximum

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-03 Thread Mimi Zohar
On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > Udit Agarwal wrote: > > > +== > > +Secure Key > > +== > > + > > +Secure key is the new type added to kernel key ring service. > > +Secure key is a symmetric type key of minimum length 32 bytes > > +and with maximum

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-02 Thread James Bottomley
On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > Udit Agarwal wrote: > > > +== > > +Secure Key > > +== > > + > > +Secure key is the new type added to kernel key ring service. > > +Secure key is a symmetric type key of minimum length 32 bytes > > +and with maximum

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-02 Thread James Bottomley
On Thu, 2018-08-02 at 17:14 +0100, David Howells wrote: > Udit Agarwal wrote: > > > +== > > +Secure Key > > +== > > + > > +Secure key is the new type added to kernel key ring service. > > +Secure key is a symmetric type key of minimum length 32 bytes > > +and with maximum

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-02 Thread David Howells
Udit Agarwal wrote: > +== > +Secure Key > +== > + > +Secure key is the new type added to kernel key ring service. > +Secure key is a symmetric type key of minimum length 32 bytes > +and with maximum possible length to be 128 bytes. It is produced > +in kernel using the CAAM

Re: [PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-08-02 Thread David Howells
Udit Agarwal wrote: > +== > +Secure Key > +== > + > +Secure key is the new type added to kernel key ring service. > +Secure key is a symmetric type key of minimum length 32 bytes > +and with maximum possible length to be 128 bytes. It is produced > +in kernel using the CAAM

[PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-23 Thread Udit Agarwal
Secure keys are derieved using CAAM crypto block. Secure keys derieved are the random number symmetric keys from CAAM. Blobs corresponding to the key are formed using CAAM. User space will only be able to view the blob of the key. Signed-off-by: Udit Agarwal Reviewed-by: Sahil Malhotra ---

[PATCH v2 1/2] security/keys/secure_key: Adds the secure key support based on CAAM.

2018-07-23 Thread Udit Agarwal
Secure keys are derieved using CAAM crypto block. Secure keys derieved are the random number symmetric keys from CAAM. Blobs corresponding to the key are formed using CAAM. User space will only be able to view the blob of the key. Signed-off-by: Udit Agarwal Reviewed-by: Sahil Malhotra ---