Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-29 Thread Patrick Donnelly
Hi Peter, On Sun, Jun 28, 2015 at 3:27 PM, Peter Hurley wrote: > The label name changing is not really necessary and would reduce diff count. I've removed the label changes in the next series. Thanks for the feedback. > It would be nice to get the printk() out from the locks as well (in a >

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-29 Thread Patrick Donnelly
Hi Peter, On Sun, Jun 28, 2015 at 3:27 PM, Peter Hurley pe...@hurleysoftware.com wrote: The label name changing is not really necessary and would reduce diff count. I've removed the label changes in the next series. Thanks for the feedback. It would be nice to get the printk() out from the

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
Hi Patrick, On 06/27/2015 08:51 PM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. > > Signed-off-by: Patrick Donnelly > --- >

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
On 06/28/2015 01:20 PM, Patrick Donnelly wrote: > On Sun, Jun 28, 2015 at 11:23 AM, Peter Hurley > wrote: >> On 06/27/2015 08:51 PM, Patrick Donnelly wrote: >>> task_pgrp requires an rcu or tasklist lock to be obtained if the returned >>> pid >>> is to be dereferenced, which kill_pgrp does.

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Patrick Donnelly
On Sun, Jun 28, 2015 at 11:23 AM, Peter Hurley wrote: > On 06/27/2015 08:51 PM, Patrick Donnelly wrote: >> task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid >> is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the >> duration of use. > > kill_pgrp()

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
On 06/27/2015 08:51 PM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. kill_pgrp() obtains tasklist_lock, so I don't see an unsafe deref. >

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
On 06/27/2015 08:51 PM, Patrick Donnelly wrote: task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the duration of use. kill_pgrp() obtains tasklist_lock, so I don't see an unsafe deref.

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Patrick Donnelly
On Sun, Jun 28, 2015 at 11:23 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 06/27/2015 08:51 PM, Patrick Donnelly wrote: task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the duration of use.

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
On 06/28/2015 01:20 PM, Patrick Donnelly wrote: On Sun, Jun 28, 2015 at 11:23 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 06/27/2015 08:51 PM, Patrick Donnelly wrote: task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
Hi Patrick, On 06/27/2015 08:51 PM, Patrick Donnelly wrote: task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the duration of use. Signed-off-by: Patrick Donnelly batr...@batbytes.com ---

[PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-27 Thread Patrick Donnelly
task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the duration of use. Signed-off-by: Patrick Donnelly --- drivers/tty/tty_io.c | 24 +++- 1 file changed, 15 insertions(+), 9

[PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-27 Thread Patrick Donnelly
task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the duration of use. Signed-off-by: Patrick Donnelly batr...@batbytes.com --- drivers/tty/tty_io.c | 24 +++- 1 file changed, 15