Re: [PATCH v2 1/2] vTPM: support little endian guests

2015-06-17 Thread Hon Ching (Vicky) Lo
Hi Ashley, Ah, good catch. I think I can only join the first two lines (where the assignments are) and will have to leave the rest splitted. I'll resubmit this one soon. Thanks for the review! Vicky On Tue, 2015-06-16 at 20:17 -0500, Ashley Lai wrote: > Just a small comment otherwise it

Re: [PATCH v2 1/2] vTPM: support little endian guests

2015-06-17 Thread Hon Ching (Vicky) Lo
Hi Ashley, Ah, good catch. I think I can only join the first two lines (where the assignments are) and will have to leave the rest splitted. I'll resubmit this one soon. Thanks for the review! Vicky On Tue, 2015-06-16 at 20:17 -0500, Ashley Lai wrote: Just a small comment otherwise it

Re: [PATCH v2 1/2] vTPM: support little endian guests

2015-06-16 Thread Ashley Lai
Just a small comment otherwise it looks good. On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: case NONHOST_INFO: - name = tcpa_event_type_strings[event->event_type]; + name = + tcpa_event_type_strings[do_endian_conversion +

Re: [PATCH v2 1/2] vTPM: support little endian guests

2015-06-16 Thread Ashley Lai
Just a small comment otherwise it looks good. On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: case NONHOST_INFO: - name = tcpa_event_type_strings[event-event_type]; + name = + tcpa_event_type_strings[do_endian_conversion +

[PATCH v2 1/2] vTPM: support little endian guests

2015-06-09 Thread Hon Ching(Vicky) Lo
This patch makes the code endianness independent. We defined a macro do_endian_conversion to apply endianness to raw integers in the event entries so that they will be displayed properly. tpm_binary_bios_measurements_show() is modified for the display. Signed-off-by: Hon Ching(Vicky) Lo

[PATCH v2 1/2] vTPM: support little endian guests

2015-06-09 Thread Hon Ching(Vicky) Lo
This patch makes the code endianness independent. We defined a macro do_endian_conversion to apply endianness to raw integers in the event entries so that they will be displayed properly. tpm_binary_bios_measurements_show() is modified for the display. Signed-off-by: Hon Ching(Vicky) Lo