Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-15 Thread Yan Zhao
On Tue, May 14, 2019 at 11:01:42PM +0800, Alex Williamson wrote: > On Tue, 14 May 2019 09:43:44 +0200 > Erik Skultety wrote: > > > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > > > On Tue, May 14, 2019 at 02:12

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-10 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Thu, 9 May 2019 17:48:26 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Thu, 9 May 2019 16:48:57 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Cornelia Huck (coh...@redhat.com) wro

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Thu, 9 May 2019 16:48:57 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Tue, 7 May 2019 15:18:26 -0600 > > > Alex Williamson wrote: > > > > > > > On Sun, 5 May 2019 21:49:04 -0400 > > > > Yan Z

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Cornelia Huck
On Tue, 7 May 2019 15:18:26 -0600 Alex Williamson wrote: > On Sun, 5 May 2019 21:49:04 -0400 > Yan Zhao wrote: > > + Errno: > > + If vendor driver wants to claim a mdev device incompatible to all other > > mdev > > + devices, it should not register version attribute for this mdev device.

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-08 Thread Alex Williamson
On Wed, 8 May 2019 07:27:40 -0400 Yan Zhao wrote: > On Wed, May 08, 2019 at 05:18:26AM +0800, Alex Williamson wrote: > > On Sun, 5 May 2019 21:49:04 -0400 > > Yan Zhao wrote: > > > > > version attribute is used to check two mdev devices' compatibility. > > > > > > The key point of this vers

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-07 Thread Alex Williamson
On Sun, 5 May 2019 21:49:04 -0400 Yan Zhao wrote: > version attribute is used to check two mdev devices' compatibility. > > The key point of this version attribute is that it's rw. > User space has no need to understand internal of device version and no > need to compare versions by itself. > C