Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-07 Thread Todd Kjos
On Thu, Dec 6, 2018 at 11:08 PM Greg Kroah-Hartman wrote: ... > But I thought I applied this back on November 26: > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?h=char-misc-testing=324fa64cf4189094bc4df744a9e7214a1b81d845 > > You should have gotten an

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-07 Thread Todd Kjos
On Thu, Dec 6, 2018 at 11:08 PM Greg Kroah-Hartman wrote: ... > But I thought I applied this back on November 26: > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?h=char-misc-testing=324fa64cf4189094bc4df744a9e7214a1b81d845 > > You should have gotten an

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Greg Kroah-Hartman
On Thu, Dec 06, 2018 at 08:37:41AM -0800, Todd Kjos wrote: > On Thu, Dec 6, 2018 at 6:51 AM Greg KH wrote: > > > > On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > > > Add __acquire()/__release() annnotations to fix warnings > > > in sparse context checking > > > > > > There is one

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Greg Kroah-Hartman
On Thu, Dec 06, 2018 at 08:37:41AM -0800, Todd Kjos wrote: > On Thu, Dec 6, 2018 at 6:51 AM Greg KH wrote: > > > > On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > > > Add __acquire()/__release() annnotations to fix warnings > > > in sparse context checking > > > > > > There is one

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Todd Kjos
On Thu, Dec 6, 2018 at 6:51 AM Greg KH wrote: > > On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > > Add __acquire()/__release() annnotations to fix warnings > > in sparse context checking > > > > There is one case where the warning was due to a lack of > > a "default:" case in a

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Todd Kjos
On Thu, Dec 6, 2018 at 6:51 AM Greg KH wrote: > > On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > > Add __acquire()/__release() annnotations to fix warnings > > in sparse context checking > > > > There is one case where the warning was due to a lack of > > a "default:" case in a

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > Add __acquire()/__release() annnotations to fix warnings > in sparse context checking > > There is one case where the warning was due to a lack of > a "default:" case in a switch statement where a lock was > being released in each of

Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-06 Thread Greg KH
On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > Add __acquire()/__release() annnotations to fix warnings > in sparse context checking > > There is one case where the warning was due to a lack of > a "default:" case in a switch statement where a lock was > being released in each of

[PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-05 Thread Todd Kjos
Add __acquire()/__release() annnotations to fix warnings in sparse context checking There is one case where the warning was due to a lack of a "default:" case in a switch statement where a lock was being released in each of the cases, so the default case was added. Signed-off-by: Todd Kjos ---

[PATCH v2 1/3] binder: fix sparse warnings on locking context

2018-12-05 Thread Todd Kjos
Add __acquire()/__release() annnotations to fix warnings in sparse context checking There is one case where the warning was due to a lack of a "default:" case in a switch statement where a lock was being released in each of the cases, so the default case was added. Signed-off-by: Todd Kjos ---