Re: [PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-04 Thread David C Niemi
Thanks for the detailed response. I am heartened by the edge cases (true idle and above up_threshold) remaining the same, that sounds like it should cover a lot of ground well. David C Niemi On 06/04/13 11:20, Stratos Karafotis wrote: > Hi David, > Thanks for your comments! > > In your

Re: [PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-04 Thread Stratos Karafotis
On 06/03/2013 11:38 PM, David C Niemi wrote: > > Interesting analysis; I just got back from vacation and have not had a chance > to comment until now. > > I like Stratos' general idea of making the decision to upshift or downshift > independent of current frequency, as it makes thinks simpler

Re: [PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-04 Thread Stratos Karafotis
On 06/03/2013 11:38 PM, David C Niemi wrote: Interesting analysis; I just got back from vacation and have not had a chance to comment until now. I like Stratos' general idea of making the decision to upshift or downshift independent of current frequency, as it makes thinks simpler and

Re: [PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-04 Thread David C Niemi
Thanks for the detailed response. I am heartened by the edge cases (true idle and above up_threshold) remaining the same, that sounds like it should cover a lot of ground well. David C Niemi On 06/04/13 11:20, Stratos Karafotis wrote: Hi David, Thanks for your comments! In your case,

Re: [PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-03 Thread David C Niemi
Interesting analysis; I just got back from vacation and have not had a chance to comment until now. I like Stratos' general idea of making the decision to upshift or downshift independent of current frequency, as it makes thinks simpler and potentially more stable. But I believe it will be

[PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-03 Thread Stratos Karafotis
Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater than up_threshold multiplied by current or average frequency. This seems to produce oscillations of frequency between min and max because, for example, a relatively small load can easily saturate

[PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-03 Thread Stratos Karafotis
Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater than up_threshold multiplied by current or average frequency. This seems to produce oscillations of frequency between min and max because, for example, a relatively small load can easily saturate

Re: [PATCH v2 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-03 Thread David C Niemi
Interesting analysis; I just got back from vacation and have not had a chance to comment until now. I like Stratos' general idea of making the decision to upshift or downshift independent of current frequency, as it makes thinks simpler and potentially more stable. But I believe it will be