Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Tue, Oct 10, 2017 at 5:34 PM, 'Dmitry Vyukov' via syzkaller wrote: > On Tue, Oct 10, 2017 at 5:28 PM, 'Alexander Potapenko' via syzkaller > wrote: >> On Mon, Oct 9, 2017 at 8:46 AM, Mark Rutland wrote: >>> Hi, >>>

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Tue, Oct 10, 2017 at 5:34 PM, 'Dmitry Vyukov' via syzkaller wrote: > On Tue, Oct 10, 2017 at 5:28 PM, 'Alexander Potapenko' via syzkaller > wrote: >> On Mon, Oct 9, 2017 at 8:46 AM, Mark Rutland wrote: >>> Hi, >>> >>> I look forward to using this! :) >>> >>> I just have afew comments below.

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Tue, Oct 10, 2017 at 5:28 PM, 'Alexander Potapenko' via syzkaller wrote: > On Mon, Oct 9, 2017 at 8:46 AM, Mark Rutland wrote: >> Hi, >> >> I look forward to using this! :) >> >> I just have afew comments below. >> >> On Mon, Oct 09, 2017 at

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Tue, Oct 10, 2017 at 5:28 PM, 'Alexander Potapenko' via syzkaller wrote: > On Mon, Oct 9, 2017 at 8:46 AM, Mark Rutland wrote: >> Hi, >> >> I look forward to using this! :) >> >> I just have afew comments below. >> >> On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: >>>

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 9, 2017 at 8:46 AM, Mark Rutland wrote: > Hi, > > I look forward to using this! :) > > I just have afew comments below. > > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: >> +/* >> + * Defines the format for the types of collected

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 9, 2017 at 8:46 AM, Mark Rutland wrote: > Hi, > > I look forward to using this! :) > > I just have afew comments below. > > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: >> +/* >> + * Defines the format for the types of collected comparisons. >> + */ >> +enum

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 09, 2017 at 08:46:18PM +0200, 'Dmitry Vyukov' via syzkaller wrote: > On Mon, Oct 9, 2017 at 8:37 PM, Mark Rutland wrote: > > On Mon, Oct 09, 2017 at 08:15:10PM +0200, 'Dmitry Vyukov' via syzkaller > > wrote: > >> On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 09, 2017 at 08:46:18PM +0200, 'Dmitry Vyukov' via syzkaller wrote: > On Mon, Oct 9, 2017 at 8:37 PM, Mark Rutland wrote: > > On Mon, Oct 09, 2017 at 08:15:10PM +0200, 'Dmitry Vyukov' via syzkaller > > wrote: > >> On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland wrote: > >> > On Mon, Oct

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 9, 2017 at 8:37 PM, Mark Rutland wrote: > On Mon, Oct 09, 2017 at 08:15:10PM +0200, 'Dmitry Vyukov' via syzkaller wrote: >> On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland wrote: >> > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 9, 2017 at 8:37 PM, Mark Rutland wrote: > On Mon, Oct 09, 2017 at 08:15:10PM +0200, 'Dmitry Vyukov' via syzkaller wrote: >> On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland wrote: >> > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: > >> > ... I note that a few

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 09, 2017 at 08:15:10PM +0200, 'Dmitry Vyukov' via syzkaller wrote: > On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland wrote: > > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: > > ... I note that a few places in the kernel use a 128-bit type.

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 09, 2017 at 08:15:10PM +0200, 'Dmitry Vyukov' via syzkaller wrote: > On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland wrote: > > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: > > ... I note that a few places in the kernel use a 128-bit type. Are > > 128-bit

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland wrote: > Hi, > > I look forward to using this! :) > > I just have afew comments below. > > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: >> +/* >> + * Defines the format for the types of collected

Re: [PATCH v2 1/3] kcov: support comparison operands collection

On Mon, Oct 9, 2017 at 5:46 PM, Mark Rutland wrote: > Hi, > > I look forward to using this! :) > > I just have afew comments below. > > On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: >> +/* >> + * Defines the format for the types of collected comparisons. >> + */ >> +enum

Re: [PATCH v2 1/3] kcov: support comparison operands collection

Hi, I look forward to using this! :) I just have afew comments below. On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: > +/* > + * Defines the format for the types of collected comparisons. > + */ > +enum kcov_cmp_type { > + /* > + * LSB shows whether one of the

Re: [PATCH v2 1/3] kcov: support comparison operands collection

Hi, I look forward to using this! :) I just have afew comments below. On Mon, Oct 09, 2017 at 05:05:19PM +0200, Alexander Potapenko wrote: > +/* > + * Defines the format for the types of collected comparisons. > + */ > +enum kcov_cmp_type { > + /* > + * LSB shows whether one of the

[PATCH v2 1/3] kcov: support comparison operands collection

From: Victor Chibotaru Enables kcov to collect comparison operands from instrumented code. This is done by using Clang's -fsanitize=trace-cmp instrumentation (currently not available for GCC). The comparison operands help a lot in fuzz testing. E.g. they are used in Syzkaller

[PATCH v2 1/3] kcov: support comparison operands collection

From: Victor Chibotaru Enables kcov to collect comparison operands from instrumented code. This is done by using Clang's -fsanitize=trace-cmp instrumentation (currently not available for GCC). The comparison operands help a lot in fuzz testing. E.g. they are used in Syzkaller to cover the