Re: [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert()

2020-08-04 Thread Petr Mladek
On Sat 2020-08-01 13:46:20, Sergey Senozhatsky wrote: > On (20/07/31 21:08), Andy Shevchenko wrote: > > First of all, there is no compile time check for the SMALL > > to be ' ' (0x20, i.e. space). Second, for ZEROPAD the check > > is hidden in the code. > > > > For better maintenance replace

Re: [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert()

2020-07-31 Thread Sergey Senozhatsky
On (20/07/31 21:08), Andy Shevchenko wrote: > First of all, there is no compile time check for the SMALL > to be ' ' (0x20, i.e. space). Second, for ZEROPAD the check > is hidden in the code. > > For better maintenance replace BUILD_BUG_ON() with static_assert() > for ZEROPAD and move it closer

Re: [PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert()

2020-07-31 Thread Sergey Senozhatsky
On (20/07/31 21:08), Andy Shevchenko wrote: > First of all, there is no compile time check for the SMALL > to be ' ' (0x20, i.e. space). Second, for ZEROPAD the check > is hidden in the code. > > For better maintenance replace BUILD_BUG_ON() with static_assert() > for ZEROPAD and move it closer

[PATCH v2 1/3] lib/vsprintf: Replace hidden BUILD_BUG_ON() with static_assert()

2020-07-31 Thread Andy Shevchenko
First of all, there is no compile time check for the SMALL to be ' ' (0x20, i.e. space). Second, for ZEROPAD the check is hidden in the code. For better maintenance replace BUILD_BUG_ON() with static_assert() for ZEROPAD and move it closer to the definition. While at it, introduce check for