I have to break the line since it's over 80 characters : ) I'll follow
CodingStyle and send a new patch.
Thanks,
jin
On Wed, May 6, 2015 at 3:39 PM, Rafael J. Wysocki wrote:
> On Wednesday, May 06, 2015 03:11:48 PM Jin Qian wrote:
>> Hi Rafael,
>>
>> I kept braces since checkpatch.pl didn't
On Wednesday, May 06, 2015 03:11:48 PM Jin Qian wrote:
> Hi Rafael,
>
> I kept braces since checkpatch.pl didn't report error or warning. The
> if condition has two lines, a brace make the statement more clear I
> think.
Well, you don't have to break the "if" line. :-)
As per CodingStyle, the
Hi Rafael,
I kept braces since checkpatch.pl didn't report error or warning. The
if condition has two lines, a brace make the statement more clear I
think.
I removed the format string since ws->name can be random strings if
the wakeup_source is not registered (i.e. using prepare functions).
It's
On Wednesday, May 06, 2015 11:51:07 AM Jin Qian wrote:
> A rogue wakeup source not registered in wakeup_sources list is not visible
> from wakeup_sources_stats_show. Check if the wakeup source is registered
> properly by looking at the timer struct.
>
> Signed-off-by: Jin Qian
> ---
>
A rogue wakeup source not registered in wakeup_sources list is not visible
from wakeup_sources_stats_show. Check if the wakeup source is registered
properly by looking at the timer struct.
Signed-off-by: Jin Qian
---
drivers/base/power/wakeup.c | 19 +++
1 file changed, 19
Hi Rafael,
I kept braces since checkpatch.pl didn't report error or warning. The
if condition has two lines, a brace make the statement more clear I
think.
I removed the format string since ws-name can be random strings if
the wakeup_source is not registered (i.e. using prepare functions).
It's
I have to break the line since it's over 80 characters : ) I'll follow
CodingStyle and send a new patch.
Thanks,
jin
On Wed, May 6, 2015 at 3:39 PM, Rafael J. Wysocki r...@rjwysocki.net wrote:
On Wednesday, May 06, 2015 03:11:48 PM Jin Qian wrote:
Hi Rafael,
I kept braces since checkpatch.pl
On Wednesday, May 06, 2015 03:11:48 PM Jin Qian wrote:
Hi Rafael,
I kept braces since checkpatch.pl didn't report error or warning. The
if condition has two lines, a brace make the statement more clear I
think.
Well, you don't have to break the if line. :-)
As per CodingStyle, the braces
On Wednesday, May 06, 2015 11:51:07 AM Jin Qian wrote:
A rogue wakeup source not registered in wakeup_sources list is not visible
from wakeup_sources_stats_show. Check if the wakeup source is registered
properly by looking at the timer struct.
Signed-off-by: Jin Qian jinq...@android.com
---
A rogue wakeup source not registered in wakeup_sources list is not visible
from wakeup_sources_stats_show. Check if the wakeup source is registered
properly by looking at the timer struct.
Signed-off-by: Jin Qian jinq...@android.com
---
drivers/base/power/wakeup.c | 19 +++
1
On Tuesday, May 05, 2015 03:24:13 PM Jin Qian wrote:
> A rogue wakeup source not registered in wakeup_sources list is not visible
> from wakeup_sources_stats_show. Check if the wakeup source is registered
> properly by looking at the timer function.
>
> Signed-off-by: Jin Qian
> ---
>
A rogue wakeup source not registered in wakeup_sources list is not visible
from wakeup_sources_stats_show. Check if the wakeup source is registered
properly by looking at the timer function.
Signed-off-by: Jin Qian
---
drivers/base/power/wakeup.c | 19 +++
1 file changed, 19
On Tuesday, May 05, 2015 03:24:13 PM Jin Qian wrote:
A rogue wakeup source not registered in wakeup_sources list is not visible
from wakeup_sources_stats_show. Check if the wakeup source is registered
properly by looking at the timer function.
Signed-off-by: Jin Qian jinq...@android.com
---
A rogue wakeup source not registered in wakeup_sources list is not visible
from wakeup_sources_stats_show. Check if the wakeup source is registered
properly by looking at the timer function.
Signed-off-by: Jin Qian jinq...@android.com
---
drivers/base/power/wakeup.c | 19 +++
1
14 matches
Mail list logo
