Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

2015-08-19 Thread Andy Lutomirski
On Mon, Aug 17, 2015 at 4:18 AM, Andy Shevchenko wrote: > On Sat, Jul 25, 2015 at 8:57 AM, Andy Lutomirski wrote: >> This will allow IRQ stacks to nest inside NMIs or similar entries >> that can happen during IRQ stack setup or teardown. >> >> The Xen code here has a confusing comment. >> >> The

Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

2015-08-17 Thread Andy Shevchenko
On Sat, Jul 25, 2015 at 8:57 AM, Andy Lutomirski wrote: > This will allow IRQ stacks to nest inside NMIs or similar entries > that can happen during IRQ stack setup or teardown. > > The Xen code here has a confusing comment. > > The new macros won't work correctly if they're invoked with IRQs on.

Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

2015-07-28 Thread Borislav Petkov
On Fri, Jul 24, 2015 at 10:57:04PM -0700, Andy Lutomirski wrote: > This will allow IRQ stacks to nest inside NMIs or similar entries > that can happen during IRQ stack setup or teardown. > > The Xen code here has a confusing comment. > > The new macros won't work correctly if they're invoked with

Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

2015-07-26 Thread Andy Lutomirski
On Sat, Jul 25, 2015 at 11:05 PM, Borislav Petkov wrote: > On Fri, Jul 24, 2015 at 10:57:04PM -0700, Andy Lutomirski wrote: >> This will allow IRQ stacks to nest inside NMIs or similar entries >> that can happen during IRQ stack setup or teardown. >> >> The Xen code here has a confusing comment. >

Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

2015-07-25 Thread Borislav Petkov
On Fri, Jul 24, 2015 at 10:57:04PM -0700, Andy Lutomirski wrote: > This will allow IRQ stacks to nest inside NMIs or similar entries > that can happen during IRQ stack setup or teardown. > > The Xen code here has a confusing comment. > > The new macros won't work correctly if they're invoked with

[PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe

2015-07-24 Thread Andy Lutomirski
This will allow IRQ stacks to nest inside NMIs or similar entries that can happen during IRQ stack setup or teardown. The Xen code here has a confusing comment. The new macros won't work correctly if they're invoked with IRQs on. Add a check under CONFIG_DEBUG_ENTRY to detect that. Signed-off-by