Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-06-03 Thread Linus Walleij
On Fri, May 29, 2020 at 12:27 AM Stephen Boyd wrote: > Quoting Linus Walleij (2020-05-28 14:33:36) > > On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > > > > > With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' > > > gpiolib > > > overrides irqchip's irq_enable and

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-29 Thread Maulik Shah
Hi, On 5/29/2020 3:52 AM, Stephen Boyd wrote: Quoting Maulik Shah (2020-05-28 06:11:23) Hi, On 5/28/2020 6:38 AM, Stephen Boyd wrote: Quoting Maulik Shah (2020-05-27 04:26:14) On 5/27/2020 3:14 PM, Stephen Boyd wrote: Quoting Maulik Shah (2020-05-23 10:11:10) diff --git

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-28 Thread Stephen Boyd
Quoting Maulik Shah (2020-05-28 06:11:23) > Hi, > > On 5/28/2020 6:38 AM, Stephen Boyd wrote: > > Quoting Maulik Shah (2020-05-27 04:26:14) > >> On 5/27/2020 3:14 PM, Stephen Boyd wrote: > >>> Quoting Maulik Shah (2020-05-23 10:11:10) > diff --git a/drivers/gpio/gpiolib.c

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-28 Thread Linus Walleij
On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib > overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable > callback is implemented then genirq takes unlazy path to disable irq. > > Underlying

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-28 Thread Maulik Shah
Hi, On 5/28/2020 6:38 AM, Stephen Boyd wrote: Quoting Maulik Shah (2020-05-27 04:26:14) On 5/27/2020 3:14 PM, Stephen Boyd wrote: Quoting Maulik Shah (2020-05-23 10:11:10) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index eaa0e20..3810cd0 100644 --- a/drivers/gpio/gpiolib.c

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-27 Thread Stephen Boyd
Quoting Maulik Shah (2020-05-27 04:26:14) > On 5/27/2020 3:14 PM, Stephen Boyd wrote: > > Quoting Maulik Shah (2020-05-23 10:11:10) > >> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > >> index eaa0e20..3810cd0 100644 > >> --- a/drivers/gpio/gpiolib.c > >> +++

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-27 Thread Russell King - ARM Linux admin
On Wed, May 27, 2020 at 03:56:16PM +0200, Linus Walleij wrote: > On Wed, May 27, 2020 at 12:38 PM Hans Verkuil wrote: > > > However, I discovered that patch 256efaea1fdc ("gpiolib: fix up emulated > > open drain outputs") broke the cec-gpio driver on the Raspberry Pi starting > > with kernel

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-27 Thread Linus Walleij
On Wed, May 27, 2020 at 12:38 PM Hans Verkuil wrote: > However, I discovered that patch 256efaea1fdc ("gpiolib: fix up emulated > open drain outputs") broke the cec-gpio driver on the Raspberry Pi starting > with kernel v5.5. > > The CEC pin is an open drain pin that is used in both input and

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-27 Thread Maulik Shah
Hi, On 5/27/2020 3:14 PM, Stephen Boyd wrote: Quoting Maulik Shah (2020-05-23 10:11:10) With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable callback is implemented then genirq takes unlazy path to

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-27 Thread Hans Verkuil
On 25/05/2020 13:55, Linus Walleij wrote: > On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > >> With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib >> overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable >> callback is implemented then genirq takes

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-27 Thread Stephen Boyd
Quoting Maulik Shah (2020-05-23 10:11:10) > With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib > overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable > callback is implemented then genirq takes unlazy path to disable irq. > > Underlying irqchip may not

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-25 Thread Maulik Shah
Hi, On 5/25/2020 5:52 PM, Hans Verkuil wrote: On 25/05/2020 13:55, Linus Walleij wrote: On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-25 Thread Hans Verkuil
On 25/05/2020 13:55, Linus Walleij wrote: > On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > >> With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib >> overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable >> callback is implemented then genirq takes

Re: [PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-25 Thread Linus Walleij
On Sat, May 23, 2020 at 7:11 PM Maulik Shah wrote: > With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib > overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable > callback is implemented then genirq takes unlazy path to disable irq. > > Underlying

[PATCH v2 1/4] gpio: gpiolib: Allow GPIO IRQs to lazy disable

2020-05-23 Thread Maulik Shah
With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable callback is implemented then genirq takes unlazy path to disable irq. Underlying irqchip may not want to implement irq_disable callback to lazy