Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-20 Thread Paul E. McKenney
On Thu, Mar 17, 2016 at 08:17:59PM -0400, Chris Metcalf wrote: > On 3/17/2016 6:55 PM, Paul E. McKenney wrote: > >The RCU stall-warn stack traces can be ugly, agreed. > > > >That said, RCU used to use NMI-based stack traces, but switched to the > >current scheme due to the NMIs having the

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-20 Thread Paul E. McKenney
On Thu, Mar 17, 2016 at 08:17:59PM -0400, Chris Metcalf wrote: > On 3/17/2016 6:55 PM, Paul E. McKenney wrote: > >The RCU stall-warn stack traces can be ugly, agreed. > > > >That said, RCU used to use NMI-based stack traces, but switched to the > >current scheme due to the NMIs having the

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 06:41:42PM -0400, Chris Metcalf wrote: > The build bot caught the fact that I missed arch/xtensa since it doesn't use > LOCK_TEXT, so if you're testing on that (ok maybe unlikely) you can add this: Ha!, no. regular boring x86_64.

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 06:41:42PM -0400, Chris Metcalf wrote: > The build bot caught the fact that I missed arch/xtensa since it doesn't use > LOCK_TEXT, so if you're testing on that (ok maybe unlikely) you can add this: Ha!, no. regular boring x86_64.

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus but yourself. It can also be helpful to request a remote backtrace of a single cpu, and since we want that, the

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus but yourself. It can also be helpful to request a remote backtrace of a single cpu, and since we want that, the

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 03:55:57PM -0700, Paul E. McKenney wrote: > The RCU stall-warn stack traces can be ugly, agreed. Ugly isn't the problem, completely random bollocks that puts you on the wrong path was more the problem. It uses a stack pointer saved at some random time in the past to start

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 03:55:57PM -0700, Paul E. McKenney wrote: > The RCU stall-warn stack traces can be ugly, agreed. Ugly isn't the problem, completely random bollocks that puts you on the wrong path was more the problem. It uses a stack pointer saved at some random time in the past to start

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 6:55 PM, Paul E. McKenney wrote: The RCU stall-warn stack traces can be ugly, agreed. That said, RCU used to use NMI-based stack traces, but switched to the current scheme due to the NMIs having the unfortunate habit of locking things up, which IIRC often meant no stack traces at

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 6:55 PM, Paul E. McKenney wrote: The RCU stall-warn stack traces can be ugly, agreed. That said, RCU used to use NMI-based stack traces, but switched to the current scheme due to the NMIs having the unfortunate habit of locking things up, which IIRC often meant no stack traces at

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Daniel Thompson
On 18/03/16 00:33, Paul E. McKenney wrote: On Thu, Mar 17, 2016 at 08:17:59PM -0400, Chris Metcalf wrote: On 3/17/2016 6:55 PM, Paul E. McKenney wrote: The RCU stall-warn stack traces can be ugly, agreed. That said, RCU used to use NMI-based stack traces, but switched to the current scheme

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Daniel Thompson
On 18/03/16 00:33, Paul E. McKenney wrote: On Thu, Mar 17, 2016 at 08:17:59PM -0400, Chris Metcalf wrote: On 3/17/2016 6:55 PM, Paul E. McKenney wrote: The RCU stall-warn stack traces can be ugly, agreed. That said, RCU used to use NMI-based stack traces, but switched to the current scheme

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 03:55:57PM -0700, Paul E. McKenney wrote: > That said, RCU used to use NMI-based stack traces, but switched to the > current scheme due to the NMIs having the unfortunate habit of locking > things up, which IIRC often meant no stack traces at all. If I recall > correctly,

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 03:55:57PM -0700, Paul E. McKenney wrote: > That said, RCU used to use NMI-based stack traces, but switched to the > current scheme due to the NMIs having the unfortunate habit of locking > things up, which IIRC often meant no stack traces at all. If I recall > correctly,

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Paul E. McKenney
On Fri, Mar 18, 2016 at 12:11:28AM +0100, Peter Zijlstra wrote: > On Thu, Mar 17, 2016 at 03:55:57PM -0700, Paul E. McKenney wrote: > > The RCU stall-warn stack traces can be ugly, agreed. > > Ugly isn't the problem, completely random bollocks that puts you on the > wrong path was more the

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Paul E. McKenney
On Fri, Mar 18, 2016 at 12:11:28AM +0100, Peter Zijlstra wrote: > On Thu, Mar 17, 2016 at 03:55:57PM -0700, Paul E. McKenney wrote: > > The RCU stall-warn stack traces can be ugly, agreed. > > Ugly isn't the problem, completely random bollocks that puts you on the > wrong path was more the

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: > Currently you can only request a backtrace of either all cpus, or > all cpus but yourself. It can also be helpful to request a remote > backtrace of a single cpu, and since we want that, the logical > extension is to support a

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: > Currently you can only request a backtrace of either all cpus, or > all cpus but yourself. It can also be helpful to request a remote > backtrace of a single cpu, and since we want that, the logical > extension is to support a

[PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
Currently you can only request a backtrace of either all cpus, or all cpus but yourself. It can also be helpful to request a remote backtrace of a single cpu, and since we want that, the logical extension is to support a cpumask as the underlying primitive. This change modifies the existing

[PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
Currently you can only request a backtrace of either all cpus, or all cpus but yourself. It can also be helpful to request a remote backtrace of a single cpu, and since we want that, the logical extension is to support a cpumask as the underlying primitive. This change modifies the existing

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 06:31:44PM -0400, Chris Metcalf wrote: > On 3/17/2016 3:36 PM, Peter Zijlstra wrote: > >On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: > >>Currently you can only request a backtrace of either all cpus, or > >>all cpus but yourself. It can also be helpful to

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Peter Zijlstra
On Thu, Mar 17, 2016 at 06:31:44PM -0400, Chris Metcalf wrote: > On 3/17/2016 3:36 PM, Peter Zijlstra wrote: > >On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: > >>Currently you can only request a backtrace of either all cpus, or > >>all cpus but yourself. It can also be helpful to

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 6:38 PM, Peter Zijlstra wrote: On Thu, Mar 17, 2016 at 06:31:44PM -0400, Chris Metcalf wrote: On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus but

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 6:38 PM, Peter Zijlstra wrote: On Thu, Mar 17, 2016 at 06:31:44PM -0400, Chris Metcalf wrote: On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus but

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-18 Thread Paul E. McKenney
On Thu, Mar 17, 2016 at 08:36:00PM +0100, Peter Zijlstra wrote: > On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: > > Currently you can only request a backtrace of either all cpus, or > > all cpus but yourself. It can also be helpful to request a remote > > backtrace of a single

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-18 Thread Paul E. McKenney
On Thu, Mar 17, 2016 at 08:36:00PM +0100, Peter Zijlstra wrote: > On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: > > Currently you can only request a backtrace of either all cpus, or > > all cpus but yourself. It can also be helpful to request a remote > > backtrace of a single

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-18 Thread Paul E. McKenney
On Fri, Mar 18, 2016 at 09:40:25AM +, Daniel Thompson wrote: > On 18/03/16 00:33, Paul E. McKenney wrote: > >On Thu, Mar 17, 2016 at 08:17:59PM -0400, Chris Metcalf wrote: > >>On 3/17/2016 6:55 PM, Paul E. McKenney wrote: > >>>The RCU stall-warn stack traces can be ugly, agreed. > >>> >

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-18 Thread Paul E. McKenney
On Fri, Mar 18, 2016 at 09:40:25AM +, Daniel Thompson wrote: > On 18/03/16 00:33, Paul E. McKenney wrote: > >On Thu, Mar 17, 2016 at 08:17:59PM -0400, Chris Metcalf wrote: > >>On 3/17/2016 6:55 PM, Paul E. McKenney wrote: > >>>The RCU stall-warn stack traces can be ugly, agreed. > >>> >