Re: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-29 Thread Lee Jones
On Thu, 28 Nov 2013, Krzysztof Kozlowski wrote: > Rename old regmap field of "struct sec_pmic_dev" to "regmap_pmic" and > add new regmap for RTC. > > On S5M8767A registers were not properly updated and read due to usage of > the same regmap as the PMIC. This could be observed in various hangs, >

Re: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-29 Thread Lee Jones
On Thu, 28 Nov 2013, Krzysztof Kozlowski wrote: Rename old regmap field of struct sec_pmic_dev to regmap_pmic and add new regmap for RTC. On S5M8767A registers were not properly updated and read due to usage of the same regmap as the PMIC. This could be observed in various hangs, e.g. in

RE: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-28 Thread Sangbeom Kim
On Thursday, November 28, 2013 10:51 PM, Mark Brown wrote: > > On S5M8767A registers were not properly updated and read due to usage > > of the same regmap as the PMIC. This could be observed in various > > hangs, e.g. in infinite loop during waiting for UDR field change. > > Reviwed-by: Mark

Re: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-28 Thread Mark Brown
On Thu, Nov 28, 2013 at 09:09:39AM +0100, Krzysztof Kozlowski wrote: > Rename old regmap field of "struct sec_pmic_dev" to "regmap_pmic" and > add new regmap for RTC. > > On S5M8767A registers were not properly updated and read due to usage of > the same regmap as the PMIC. This could be observed

[PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-28 Thread Krzysztof Kozlowski
Rename old regmap field of "struct sec_pmic_dev" to "regmap_pmic" and add new regmap for RTC. On S5M8767A registers were not properly updated and read due to usage of the same regmap as the PMIC. This could be observed in various hangs, e.g. in infinite loop during waiting for UDR field change.

[PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-28 Thread Krzysztof Kozlowski
Rename old regmap field of struct sec_pmic_dev to regmap_pmic and add new regmap for RTC. On S5M8767A registers were not properly updated and read due to usage of the same regmap as the PMIC. This could be observed in various hangs, e.g. in infinite loop during waiting for UDR field change. On

Re: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-28 Thread Mark Brown
On Thu, Nov 28, 2013 at 09:09:39AM +0100, Krzysztof Kozlowski wrote: Rename old regmap field of struct sec_pmic_dev to regmap_pmic and add new regmap for RTC. On S5M8767A registers were not properly updated and read due to usage of the same regmap as the PMIC. This could be observed in

RE: [PATCH v2 1/5] mfd/rtc: s5m: Fix register updating by adding regmap for RTC

2013-11-28 Thread Sangbeom Kim
On Thursday, November 28, 2013 10:51 PM, Mark Brown wrote: On S5M8767A registers were not properly updated and read due to usage of the same regmap as the PMIC. This could be observed in various hangs, e.g. in infinite loop during waiting for UDR field change. Reviwed-by: Mark Brown