Re: [PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page()

On 2021/3/23 22:27, David Hildenbrand wrote: > On 23.03.21 14:54, Miaohe Lin wrote: >> The !PageLocked() check is implicitly done in PageMovable(). Remove this >> explicit one. >> >> Signed-off-by: Miaohe Lin >> --- >>   mm/migrate.c | 1 - >>   1 file changed, 1 deletion(-) >> >> diff --git

Re: [PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page()

On 2021/3/24 1:58, Yang Shi wrote: > On Tue, Mar 23, 2021 at 6:54 AM Miaohe Lin wrote: >> >> The !PageLocked() check is implicitly done in PageMovable(). Remove this >> explicit one. > > TBH, I'm a little bit reluctant to have this kind change. If "locked" > check is necessary we'd better make

Re: [PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page()

On Tue, Mar 23, 2021 at 6:54 AM Miaohe Lin wrote: > > The !PageLocked() check is implicitly done in PageMovable(). Remove this > explicit one. TBH, I'm a little bit reluctant to have this kind change. If "locked" check is necessary we'd better make it explicit otherwise just remove it. And why

Re: [PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page()

On 23.03.21 14:54, Miaohe Lin wrote: The !PageLocked() check is implicitly done in PageMovable(). Remove this explicit one. Signed-off-by: Miaohe Lin --- mm/migrate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 47df0df8f21a..facec65c7374 100644 ---

[PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page()

The !PageLocked() check is implicitly done in PageMovable(). Remove this explicit one. Signed-off-by: Miaohe Lin --- mm/migrate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 47df0df8f21a..facec65c7374 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@