Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-29 Thread Kishon Vijay Abraham I
On Tuesday 28 October 2014 12:02 AM, Sebastian Hesselbarth wrote: > On 10/27/2014 01:27 PM, Kishon Vijay Abraham I wrote: >> On Saturday 25 October 2014 01:55 AM, Felipe Balbi wrote: >>> On Fri, Oct 24, 2014 at 10:14:55PM +0200, Sebastian Hesselbarth wrote: On 21.10.2014 11:40, Sebastian Hes

Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-27 Thread Sebastian Hesselbarth
On 10/27/2014 01:27 PM, Kishon Vijay Abraham I wrote: On Saturday 25 October 2014 01:55 AM, Felipe Balbi wrote: On Fri, Oct 24, 2014 at 10:14:55PM +0200, Sebastian Hesselbarth wrote: On 21.10.2014 11:40, Sebastian Hesselbarth wrote: On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: On Tue

Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-27 Thread Kishon Vijay Abraham I
Hi, On Saturday 25 October 2014 01:55 AM, Felipe Balbi wrote: > Hi, > > On Fri, Oct 24, 2014 at 10:14:55PM +0200, Sebastian Hesselbarth wrote: >> On 21.10.2014 11:40, Sebastian Hesselbarth wrote: >>> On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: On Tuesday 21 October 2014 02:37 PM, S

Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-24 Thread Sebastian Hesselbarth
On 24.10.2014 22:25, Felipe Balbi wrote: Hi, On Fri, Oct 24, 2014 at 10:14:55PM +0200, Sebastian Hesselbarth wrote: On 21.10.2014 11:40, Sebastian Hesselbarth wrote: On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: Curren

Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-24 Thread Felipe Balbi
Hi, On Fri, Oct 24, 2014 at 10:14:55PM +0200, Sebastian Hesselbarth wrote: > On 21.10.2014 11:40, Sebastian Hesselbarth wrote: > >On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: > >>On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: > >>>Currently, Berlin SATA PHY driver assum

Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-24 Thread Sebastian Hesselbarth
On 21.10.2014 11:40, Sebastian Hesselbarth wrote: On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: Currently, Berlin SATA PHY driver assumes PHY_BASE address being constant. While this PHY_BASE is correct for BG2Q, older BG2

Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-21 Thread Sebastian Hesselbarth
On 10/21/2014 11:33 AM, Kishon Vijay Abraham I wrote: On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: Currently, Berlin SATA PHY driver assumes PHY_BASE address being constant. While this PHY_BASE is correct for BG2Q, older BG2 PHY_BASE is different. Prepare the driver for BG2

Re: [PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-21 Thread Kishon Vijay Abraham I
On Tuesday 21 October 2014 02:37 PM, Sebastian Hesselbarth wrote: > Currently, Berlin SATA PHY driver assumes PHY_BASE address being > constant. While this PHY_BASE is correct for BG2Q, older BG2 PHY_BASE > is different. Prepare the driver for BG2 support by moving the phy_base > into private dri

[PATCH v2 1/5] phy: berlin-sata: Move PHY_BASE into private data struct

2014-10-21 Thread Sebastian Hesselbarth
Currently, Berlin SATA PHY driver assumes PHY_BASE address being constant. While this PHY_BASE is correct for BG2Q, older BG2 PHY_BASE is different. Prepare the driver for BG2 support by moving the phy_base into private driver data. Acked-by: Antoine Ténart Signed-off-by: Sebastian Hesselbarth -