Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Philipp, On Fri, 2017-08-11 at 18:37 +0200, Philipp Zabel wrote: > > > +struct reset_simple_devdata { > > > > > + bool inverted; > > > > > > +}; > > > + > > > +static const struct reset_simple_devdata reset_simple_inverted = > > > { > > > + .inverted = true, > > > > Hmm. I think it would

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Philipp, On Fri, 2017-08-11 at 18:37 +0200, Philipp Zabel wrote: > > > +struct reset_simple_devdata { > > > > > + bool inverted; > > > > > > +}; > > > + > > > +static const struct reset_simple_devdata reset_simple_inverted = > > > { > > > + .inverted = true, > > > > Hmm. I think it would

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

On Fri, 2017-08-11 at 10:47 -0700, Alexandru Gagniuc wrote: > Hi Philipp, > > On 08/11/2017 06:06 AM, Philipp Zabel wrote: > [snip] > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > index 52d5251660b9b..f7ba01a71daee 100644 > > --- a/drivers/reset/Kconfig > > +++

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

On Fri, 2017-08-11 at 10:47 -0700, Alexandru Gagniuc wrote: > Hi Philipp, > > On 08/11/2017 06:06 AM, Philipp Zabel wrote: > [snip] > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > index 52d5251660b9b..f7ba01a71daee 100644 > > --- a/drivers/reset/Kconfig > > +++

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Philipp, On 08/11/2017 06:06 AM, Philipp Zabel wrote: [snip] diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 52d5251660b9b..f7ba01a71daee 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -68,6 +68,16 @@ config RESET_PISTACHIO help This

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Philipp, On 08/11/2017 06:06 AM, Philipp Zabel wrote: [snip] diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 52d5251660b9b..f7ba01a71daee 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -68,6 +68,16 @@ config RESET_PISTACHIO help This

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Alexandru, On Fri, 2017-08-11 at 09:04 -0700, Alexandru Gagniuc wrote: > Hi Phillip, > > On 08/11/2017 06:06 AM, Philipp Zabel wrote: > [snip] > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > index 52d5251660b9b..f7ba01a71daee 100644 > > --- a/drivers/reset/Kconfig > >

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Alexandru, On Fri, 2017-08-11 at 09:04 -0700, Alexandru Gagniuc wrote: > Hi Phillip, > > On 08/11/2017 06:06 AM, Philipp Zabel wrote: > [snip] > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > index 52d5251660b9b..f7ba01a71daee 100644 > > --- a/drivers/reset/Kconfig > >

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Phillip, On 08/11/2017 06:06 AM, Philipp Zabel wrote: [snip] diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 52d5251660b9b..f7ba01a71daee 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -68,6 +68,16 @@ config RESET_PISTACHIO help This

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Phillip, On 08/11/2017 06:06 AM, Philipp Zabel wrote: [snip] diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 52d5251660b9b..f7ba01a71daee 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -68,6 +68,16 @@ config RESET_PISTACHIO help This

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Dinh, On Fri, 2017-08-11 at 10:39 -0500, Dinh Nguyen wrote: > Hi Phillip, > > This patch is failing to apply on both v4.13-rc4 and linux-next: > > error: patch failed: drivers/reset/reset-sunxi.c:108 > error: drivers/reset/reset-sunxi.c: patch does not apply > Patch failed at 0001 reset: add

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Dinh, On Fri, 2017-08-11 at 10:39 -0500, Dinh Nguyen wrote: > Hi Phillip, > > This patch is failing to apply on both v4.13-rc4 and linux-next: > > error: patch failed: drivers/reset/reset-sunxi.c:108 > error: drivers/reset/reset-sunxi.c: patch does not apply > Patch failed at 0001 reset: add

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

On Fri, 2017-08-11 at 23:51 +0800, Chen-Yu Tsai wrote: > On Fri, Aug 11, 2017 at 9:06 PM, Philipp Zabel wrote: > > +static int reset_simple_probe(struct platform_device *pdev) > > +{ > > +   struct device *dev = >dev; > > +   const struct of_device_id *of_id = > >

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

On Fri, 2017-08-11 at 23:51 +0800, Chen-Yu Tsai wrote: > On Fri, Aug 11, 2017 at 9:06 PM, Philipp Zabel wrote: > > +static int reset_simple_probe(struct platform_device *pdev) > > +{ > > +   struct device *dev = >dev; > > +   const struct of_device_id *of_id = > > +   

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

On Fri, Aug 11, 2017 at 9:06 PM, Philipp Zabel wrote: > Split reusable parts out of the sunxi driver, to add a driver for simple > reset controllers with reset lines that can be controlled by toggling > bits in exclusive, contiguous register ranges using read-modify-write

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

On Fri, Aug 11, 2017 at 9:06 PM, Philipp Zabel wrote: > Split reusable parts out of the sunxi driver, to add a driver for simple > reset controllers with reset lines that can be controlled by toggling > bits in exclusive, contiguous register ranges using read-modify-write > cycles under a

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Phillip, This patch is failing to apply on both v4.13-rc4 and linux-next: error: patch failed: drivers/reset/reset-sunxi.c:108 error: drivers/reset/reset-sunxi.c: patch does not apply Patch failed at 0001 reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 On 08/11/2017 08:06

Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Hi Phillip, This patch is failing to apply on both v4.13-rc4 and linux-next: error: patch failed: drivers/reset/reset-sunxi.c:108 error: drivers/reset/reset-sunxi.c: patch does not apply Patch failed at 0001 reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 On 08/11/2017 08:06

[PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Split reusable parts out of the sunxi driver, to add a driver for simple reset controllers with reset lines that can be controlled by toggling bits in exclusive, contiguous register ranges using read-modify-write cycles under a spinlock. The separate sunxi driver still remains to register the

[PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967

Split reusable parts out of the sunxi driver, to add a driver for simple reset controllers with reset lines that can be controlled by toggling bits in exclusive, contiguous register ranges using read-modify-write cycles under a spinlock. The separate sunxi driver still remains to register the