Re: [PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-07-18 Thread poza
On 2018-07-18 03:06, Bjorn Helgaas wrote: On Tue, Jul 17, 2018 at 02:03:29PM -0500, Bjorn Helgaas wrote: Hi Oza, Thanks for doing this! On Fri, Jun 22, 2018 at 05:58:09AM -0400, Oza Pawandeep wrote: > pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset > callbacks in

Re: [PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-07-18 Thread poza
On 2018-07-18 03:06, Bjorn Helgaas wrote: On Tue, Jul 17, 2018 at 02:03:29PM -0500, Bjorn Helgaas wrote: Hi Oza, Thanks for doing this! On Fri, Jun 22, 2018 at 05:58:09AM -0400, Oza Pawandeep wrote: > pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset > callbacks in

Re: [PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-07-17 Thread Bjorn Helgaas
On Tue, Jul 17, 2018 at 02:03:29PM -0500, Bjorn Helgaas wrote: > Hi Oza, > > Thanks for doing this! > > On Fri, Jun 22, 2018 at 05:58:09AM -0400, Oza Pawandeep wrote: > > pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset > > callbacks in case of ERR_NONFATAL. > > IIRC,

Re: [PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-07-17 Thread Bjorn Helgaas
On Tue, Jul 17, 2018 at 02:03:29PM -0500, Bjorn Helgaas wrote: > Hi Oza, > > Thanks for doing this! > > On Fri, Jun 22, 2018 at 05:58:09AM -0400, Oza Pawandeep wrote: > > pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset > > callbacks in case of ERR_NONFATAL. > > IIRC,

Re: [PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-07-17 Thread Bjorn Helgaas
Hi Oza, Thanks for doing this! On Fri, Jun 22, 2018 at 05:58:09AM -0400, Oza Pawandeep wrote: > pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset > callbacks in case of ERR_NONFATAL. IIRC, the current strategy is: ERR_COR: log only ERR_NONFATAL: call driver

Re: [PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-07-17 Thread Bjorn Helgaas
Hi Oza, Thanks for doing this! On Fri, Jun 22, 2018 at 05:58:09AM -0400, Oza Pawandeep wrote: > pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset > callbacks in case of ERR_NONFATAL. IIRC, the current strategy is: ERR_COR: log only ERR_NONFATAL: call driver

[PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-06-22 Thread Oza Pawandeep
pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset callbacks in case of ERR_NONFATAL. AER uncorrectable error status should take severity into account in order to clear the bits, so that ERR_NONFATAL path does not clear the bit which are marked with severity fatal.

[PATCH v2 1/6] PCI/AER: Take severity mask into account while clearing error bits

2018-06-22 Thread Oza Pawandeep
pci_cleanup_aer_uncorrect_error_status() is called by different slot_reset callbacks in case of ERR_NONFATAL. AER uncorrectable error status should take severity into account in order to clear the bits, so that ERR_NONFATAL path does not clear the bit which are marked with severity fatal.