Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-31 Thread Ulf Hansson
On 31 May 2018 at 06:20, Rajendra Nayak wrote: > > > On 05/30/2018 06:14 PM, Ulf Hansson wrote: >> [...] >> > + > +static DEFINE_MUTEX(rpmpd_lock); > + > +/* msm8996 RPM powerdomains */ > +DEFINE_RPMPD_CORN_SMPA(msm8996, vddcx, vddcx_ao, 1); >

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-31 Thread Ulf Hansson
On 31 May 2018 at 06:20, Rajendra Nayak wrote: > > > On 05/30/2018 06:14 PM, Ulf Hansson wrote: >> [...] >> > + > +static DEFINE_MUTEX(rpmpd_lock); > + > +/* msm8996 RPM powerdomains */ > +DEFINE_RPMPD_CORN_SMPA(msm8996, vddcx, vddcx_ao, 1); >

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
On 05/30/2018 06:14 PM, Ulf Hansson wrote: > [...] > + +static DEFINE_MUTEX(rpmpd_lock); + +/* msm8996 RPM powerdomains */ +DEFINE_RPMPD_CORN_SMPA(msm8996, vddcx, vddcx_ao, 1); +DEFINE_RPMPD_CORN_SMPA(msm8996, vddmx, vddmx_ao, 2);

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
On 05/30/2018 06:14 PM, Ulf Hansson wrote: > [...] > + +static DEFINE_MUTEX(rpmpd_lock); + +/* msm8996 RPM powerdomains */ +DEFINE_RPMPD_CORN_SMPA(msm8996, vddcx, vddcx_ao, 1); +DEFINE_RPMPD_CORN_SMPA(msm8996, vddmx, vddmx_ao, 2);

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
On 05/31/2018 08:57 AM, Rob Herring wrote: > On Fri, May 25, 2018 at 03:31:16PM +0530, Rajendra Nayak wrote: >> The powerdomains for corners just pass the performance state set by the >> consumers to the RPM (Remote Power manager) which then takes care >> of setting the appropriate voltage on

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
On 05/31/2018 08:57 AM, Rob Herring wrote: > On Fri, May 25, 2018 at 03:31:16PM +0530, Rajendra Nayak wrote: >> The powerdomains for corners just pass the performance state set by the >> consumers to the RPM (Remote Power manager) which then takes care >> of setting the appropriate voltage on

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
Hi David, On 05/30/2018 11:57 PM, David Collins wrote: > Hello Rajendra, > > On 05/30/2018 03:14 AM, Rajendra Nayak wrote: >> On 05/30/2018 02:47 PM, Ulf Hansson wrote: >>> On 25 May 2018 at 12:01, Rajendra Nayak wrote: > ... + pm_genpd_init([i]->pd, NULL, true); >>> >>>

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
Hi David, On 05/30/2018 11:57 PM, David Collins wrote: > Hello Rajendra, > > On 05/30/2018 03:14 AM, Rajendra Nayak wrote: >> On 05/30/2018 02:47 PM, Ulf Hansson wrote: >>> On 25 May 2018 at 12:01, Rajendra Nayak wrote: > ... + pm_genpd_init([i]->pd, NULL, true); >>> >>>

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rob Herring
On Fri, May 25, 2018 at 03:31:16PM +0530, Rajendra Nayak wrote: > The powerdomains for corners just pass the performance state set by the > consumers to the RPM (Remote Power manager) which then takes care > of setting the appropriate voltage on the corresponding rails to > meet the performance

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rob Herring
On Fri, May 25, 2018 at 03:31:16PM +0530, Rajendra Nayak wrote: > The powerdomains for corners just pass the performance state set by the > consumers to the RPM (Remote Power manager) which then takes care > of setting the appropriate voltage on the corresponding rails to > meet the performance

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread David Collins
Hello Rajendra, On 05/30/2018 03:14 AM, Rajendra Nayak wrote: > On 05/30/2018 02:47 PM, Ulf Hansson wrote: >> On 25 May 2018 at 12:01, Rajendra Nayak wrote: ... >>> + pm_genpd_init([i]->pd, NULL, true); >> >> Question: Is there no hierarchical topology of the PM domains. No >>

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread David Collins
Hello Rajendra, On 05/30/2018 03:14 AM, Rajendra Nayak wrote: > On 05/30/2018 02:47 PM, Ulf Hansson wrote: >> On 25 May 2018 at 12:01, Rajendra Nayak wrote: ... >>> + pm_genpd_init([i]->pd, NULL, true); >> >> Question: Is there no hierarchical topology of the PM domains. No >>

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Ulf Hansson
[...] >>> + >>> +static DEFINE_MUTEX(rpmpd_lock); >>> + >>> +/* msm8996 RPM powerdomains */ >>> +DEFINE_RPMPD_CORN_SMPA(msm8996, vddcx, vddcx_ao, 1); >>> +DEFINE_RPMPD_CORN_SMPA(msm8996, vddmx, vddmx_ao, 2); >>> +DEFINE_RPMPD_CORN_LDOA(msm8996, vddsscx, 26); >>> + >>>

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Ulf Hansson
[...] >>> + >>> +static DEFINE_MUTEX(rpmpd_lock); >>> + >>> +/* msm8996 RPM powerdomains */ >>> +DEFINE_RPMPD_CORN_SMPA(msm8996, vddcx, vddcx_ao, 1); >>> +DEFINE_RPMPD_CORN_SMPA(msm8996, vddmx, vddmx_ao, 2); >>> +DEFINE_RPMPD_CORN_LDOA(msm8996, vddsscx, 26); >>> + >>>

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
On 05/30/2018 02:47 PM, Ulf Hansson wrote: > On 25 May 2018 at 12:01, Rajendra Nayak wrote: >> The powerdomains for corners just pass the performance state set by the >> consumers to the RPM (Remote Power manager) which then takes care >> of setting the appropriate voltage on the corresponding

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Rajendra Nayak
On 05/30/2018 02:47 PM, Ulf Hansson wrote: > On 25 May 2018 at 12:01, Rajendra Nayak wrote: >> The powerdomains for corners just pass the performance state set by the >> consumers to the RPM (Remote Power manager) which then takes care >> of setting the appropriate voltage on the corresponding

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Ulf Hansson
On 25 May 2018 at 12:01, Rajendra Nayak wrote: > The powerdomains for corners just pass the performance state set by the > consumers to the RPM (Remote Power manager) which then takes care > of setting the appropriate voltage on the corresponding rails to > meet the performance needs. > > We add

Re: [PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-30 Thread Ulf Hansson
On 25 May 2018 at 12:01, Rajendra Nayak wrote: > The powerdomains for corners just pass the performance state set by the > consumers to the RPM (Remote Power manager) which then takes care > of setting the appropriate voltage on the corresponding rails to > meet the performance needs. > > We add

[PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-25 Thread Rajendra Nayak
The powerdomains for corners just pass the performance state set by the consumers to the RPM (Remote Power manager) which then takes care of setting the appropriate voltage on the corresponding rails to meet the performance needs. We add all powerdomain data needed on msm8996 here. This driver

[PATCH v2 1/6] soc: qcom: rpmpd: Add a powerdomain driver to model corners

2018-05-25 Thread Rajendra Nayak
The powerdomains for corners just pass the performance state set by the consumers to the RPM (Remote Power manager) which then takes care of setting the appropriate voltage on the corresponding rails to meet the performance needs. We add all powerdomain data needed on msm8996 here. This driver