Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-11-09 Thread Chen Weixiang
On Mon, Nov 10, 2014 at 08:16:16AM +0800, Chen Weixiang wrote: > On Mon, Nov 03, 2014 at 04:05:43PM -0800, Greg Kroah-Hartman wrote: > > > > This patch doesn't apply against my staging.git tree on git.kernel.org > > Please refresh the series against the staging-testing and resend. > > > > thanks,

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-11-09 Thread Chen Weixiang
On Mon, Nov 03, 2014 at 04:05:43PM -0800, Greg Kroah-Hartman wrote: > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c > > and ft1000/ft1000-pcmcia/ft1000_hw.c: > > ERROR: spaces required around that '=' (ctx

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-11-03 Thread Greg Kroah-Hartman
On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c > and ft1000/ft1000-pcmcia/ft1000_hw.c: > ERROR: spaces required around that '=' (ctx:VxV) > ERROR: spaces required around that '<' (ctx:VxV) > ERROR: spaces req

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-11-01 Thread Sudip Mukherjee
On Sat, Nov 01, 2014 at 10:09:39PM +0800, Chen Weixiang wrote: > On Sat, Nov 01, 2014 at 10:35:35AM +0530, Sudip Mukherjee wrote: > > many whitespace errors in the patch. > > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked > > > > thanks > > sudip > > > > Hi sudip, > > Yes, I a

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-11-01 Thread Chen Weixiang
On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote: > ok, just to verify, i thought of trying to generate a similar patch which > will not give checkpatch errors. > but this patch is not applying to next-20141031. > > thanks > sudip Hi sudip, It's my fault that I'm not fetching lat

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-11-01 Thread Chen Weixiang
On Sat, Nov 01, 2014 at 10:35:35AM +0530, Sudip Mukherjee wrote: > many whitespace errors in the patch. > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked > > thanks > sudip > Hi sudip, Yes, I also run checkpatch.pl on this patch, and got several errors/warnings. But those error

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-10-31 Thread Sudip Mukherjee
On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote: > On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote: > > On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote: > > > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > > > > Remove following code style erro

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-10-31 Thread Sudip Mukherjee
On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote: > On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote: > > On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote: > > > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > > > > Remove following code style erro

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-10-31 Thread Sudip Mukherjee
On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote: > On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote: > > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > > > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c > > > and ft1000/ft1000-pcmcia/f

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-10-31 Thread Joe Perches
On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote: > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c > > and ft1000/ft1000-pcmcia/ft1000_hw.c: > > ERROR: spaces required around that '=' (ctx:VxV) > >

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-10-31 Thread Sudip Mukherjee
On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c > and ft1000/ft1000-pcmcia/ft1000_hw.c: > ERROR: spaces required around that '=' (ctx:VxV) > ERROR: spaces required around that '<' (ctx:VxV) > ERROR: spaces req

[PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

2014-10-31 Thread Chen Weixiang
Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c and ft1000/ft1000-pcmcia/ft1000_hw.c: ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) Signed-off-by: Chen Weixiang --- driv