In the function htpic_of_init(), when kzalloc htpic fails, it should
return -ENOMEM directly, no need to execute "goto" to kfree.

Signed-off-by: Tiezhu Yang <yangtie...@loongson.cn>
---
 drivers/irqchip/irq-loongson-htpic.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/irqchip/irq-loongson-htpic.c 
b/drivers/irqchip/irq-loongson-htpic.c
index dd018c2..63f7280 100644
--- a/drivers/irqchip/irq-loongson-htpic.c
+++ b/drivers/irqchip/irq-loongson-htpic.c
@@ -93,10 +93,8 @@ int __init htpic_of_init(struct device_node *node, struct 
device_node *parent)
        }
 
        htpic = kzalloc(sizeof(*htpic), GFP_KERNEL);
-       if (!htpic) {
-               err = -ENOMEM;
-               goto out_free;
-       }
+       if (!htpic)
+               return -ENOMEM;
 
        htpic->base = of_iomap(node, 0);
        if (!htpic->base) {
-- 
2.1.0

Reply via email to