Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-26 Thread Noralf Trønnes
Den 25.04.2016 23:13, skrev Laurent Pinchart: Hi Noralf, On Monday 25 Apr 2016 20:35:18 Noralf Trønnes wrote: Den 25.04.2016 18:38, skrev Ville Syrjälä: On Mon, Apr 25, 2016 at 06:05:20PM +0200, Daniel Vetter wrote: On Mon, Apr 25, 2016 at 06:09:44PM +0300, Ville Syrjälä wrote: On Mon, Apr

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Laurent Pinchart
Hi Noralf, On Monday 25 Apr 2016 20:35:18 Noralf Trønnes wrote: > Den 25.04.2016 18:38, skrev Ville Syrjälä: > > On Mon, Apr 25, 2016 at 06:05:20PM +0200, Daniel Vetter wrote: > >> On Mon, Apr 25, 2016 at 06:09:44PM +0300, Ville Syrjälä wrote: > >>> On Mon, Apr 25, 2016 at 04:03:13PM +0200, Noralf

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Daniel Vetter
On Mon, Apr 25, 2016 at 08:35:18PM +0200, Noralf Trønnes wrote: > > Den 25.04.2016 18:38, skrev Ville Syrjälä: > >On Mon, Apr 25, 2016 at 06:05:20PM +0200, Daniel Vetter wrote: > >>On Mon, Apr 25, 2016 at 06:09:44PM +0300, Ville Syrjälä wrote: > >>>On Mon, Apr 25, 2016 at 04:03:13PM +0200, Noralf

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Noralf Trønnes
Den 25.04.2016 18:38, skrev Ville Syrjälä: On Mon, Apr 25, 2016 at 06:05:20PM +0200, Daniel Vetter wrote: On Mon, Apr 25, 2016 at 06:09:44PM +0300, Ville Syrjälä wrote: On Mon, Apr 25, 2016 at 04:03:13PM +0200, Noralf Trønnes wrote: Den 25.04.2016 15:02, skrev Ville Syrjälä: On Mon, Apr 25,

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 25, 2016 at 06:05:20PM +0200, Daniel Vetter wrote: > On Mon, Apr 25, 2016 at 06:09:44PM +0300, Ville Syrjälä wrote: > > On Mon, Apr 25, 2016 at 04:03:13PM +0200, Noralf Trønnes wrote: > > > > > > Den 25.04.2016 15:02, skrev Ville Syrjälä: > > > > On Mon, Apr 25, 2016 at 02:55:52PM +020

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Daniel Vetter
On Mon, Apr 25, 2016 at 06:09:44PM +0300, Ville Syrjälä wrote: > On Mon, Apr 25, 2016 at 04:03:13PM +0200, Noralf Trønnes wrote: > > > > Den 25.04.2016 15:02, skrev Ville Syrjälä: > > > On Mon, Apr 25, 2016 at 02:55:52PM +0200, Noralf Trønnes wrote: > > >> Den 25.04.2016 14:39, skrev Ville Syrjälä

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 25, 2016 at 04:03:13PM +0200, Noralf Trønnes wrote: > > Den 25.04.2016 15:02, skrev Ville Syrjälä: > > On Mon, Apr 25, 2016 at 02:55:52PM +0200, Noralf Trønnes wrote: > >> Den 25.04.2016 14:39, skrev Ville Syrjälä: > >>> On Sun, Apr 24, 2016 at 10:48:55PM +0200, Noralf Trønnes wrote: >

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Noralf Trønnes
Den 25.04.2016 15:02, skrev Ville Syrjälä: On Mon, Apr 25, 2016 at 02:55:52PM +0200, Noralf Trønnes wrote: Den 25.04.2016 14:39, skrev Ville Syrjälä: On Sun, Apr 24, 2016 at 10:48:55PM +0200, Noralf Trønnes wrote: Add some utility functions for struct drm_clip_rect. Looks like mostly you're

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 25, 2016 at 02:55:52PM +0200, Noralf Trønnes wrote: > > Den 25.04.2016 14:39, skrev Ville Syrjälä: > > On Sun, Apr 24, 2016 at 10:48:55PM +0200, Noralf Trønnes wrote: > >> Add some utility functions for struct drm_clip_rect. > > Looks like mostly you're just duplicating the drm_rect st

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Noralf Trønnes
Den 25.04.2016 14:39, skrev Ville Syrjälä: On Sun, Apr 24, 2016 at 10:48:55PM +0200, Noralf Trønnes wrote: Add some utility functions for struct drm_clip_rect. Looks like mostly you're just duplicating the drm_rect stuff. Why can't you use what's there already? That's because the framebuffer

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Ville Syrjälä
On Sun, Apr 24, 2016 at 10:48:55PM +0200, Noralf Trønnes wrote: > Add some utility functions for struct drm_clip_rect. Looks like mostly you're just duplicating the drm_rect stuff. Why can't you use what's there already? > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_rect.c | 67

Re: [PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-25 Thread Daniel Vetter
On Sun, Apr 24, 2016 at 10:48:55PM +0200, Noralf Trønnes wrote: > Add some utility functions for struct drm_clip_rect. > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_rect.c | 67 > include/drm/drm_rect.h | 69 >

[PATCH v2 1/8] drm/rect: Add some drm_clip_rect utility functions

2016-04-24 Thread Noralf Trønnes
Add some utility functions for struct drm_clip_rect. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_rect.c | 67 include/drm/drm_rect.h | 69 ++ 2 files changed, 136 insertions(+) diff --git a/dr