Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-08 Thread Yun Levi
> btrfs' free space cache v1 is going to be removed some time in the > future so introducing kernel-wide change just for its own sake is a bit > premature But, I think it's not quite a kernel-wide change just add the correspondent function to find_last_bit. So, if we add this feature, maybe some

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-07 Thread Yun Levi
> Use `git format-patch ...` tool. When create a series, be sure you run it: > - with -v, where is a version number (makes sense from v2) > - with --thread (it will be properly formed in a thread) > - with --cover-letter (don't forget to file the patch 0/n message) Thanks for your advice. Then

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-07 Thread Andy Shevchenko
On Sun, Dec 06, 2020 at 03:46:24PM +0900, Levi Yun wrote: > Inspired find_next_*_bit and find_last_bit, add find_last_zero_bit > And add le support about find_last_bit and find_last_zero_bit. Use `git format-patch ...` tool. When create a series, be sure you run it: - with -v, where is a version

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-06 Thread Yun Levi
> btrfs' free space cache v1 is going to be removed some time in the > future so introducing kernel-wide change just for its own sake is a bit > premature. Sorry, I don't know about this fact Thanks.. > Also do you have measurements showing it indeed improves > performances? I'm not test btrfs'

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-06 Thread Nikolay Borisov
On 6.12.20 г. 10:56 ч., Yun Levi wrote: >> This, and the change above this, are not related to this patch so you >> might not want to include them. > >> Also, why is this patch series even needed? I don't see a justification >> for it anywhere, only "what" this patch is, not "why". > > I

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-06 Thread Greg KH
On Sun, Dec 06, 2020 at 05:56:30PM +0900, Yun Levi wrote: > > This, and the change above this, are not related to this patch so you > > might not want to include them. > > > Also, why is this patch series even needed? I don't see a justification > > for it anywhere, only "what" this patch is,

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-06 Thread Yun Levi
> This, and the change above this, are not related to this patch so you > might not want to include them. > Also, why is this patch series even needed? I don't see a justification > for it anywhere, only "what" this patch is, not "why". I think the find_last_zero_bit will help to improve in 7th

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-06 Thread Yun Levi
Sorry, in 7'th patch (not 8th). Thanks Levi. On Sun, Dec 6, 2020 at 5:31 PM Greg KH wrote: > > On Sun, Dec 06, 2020 at 03:46:24PM +0900, Levi Yun wrote: > > Inspired find_next_*_bit and find_last_bit, add find_last_zero_bit > > And add le support about find_last_bit and find_last_zero_bit. > >

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-06 Thread Yun Levi
> This, and the change above this, are not related to this patch so you > might not want to include them. > > Also, why is this patch series even needed? I don't see a justification > for it anywhere, only "what" this patch is, not "why". A little part of codes are trying to find the last zero

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-06 Thread Greg KH
On Sun, Dec 06, 2020 at 03:46:24PM +0900, Levi Yun wrote: > Inspired find_next_*_bit and find_last_bit, add find_last_zero_bit > And add le support about find_last_bit and find_last_zero_bit. > > Signed-off-by: Levi Yun > --- > lib/find_bit.c | 64

[PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-05 Thread Levi Yun
Inspired find_next_*_bit and find_last_bit, add find_last_zero_bit And add le support about find_last_bit and find_last_zero_bit. Signed-off-by: Levi Yun --- lib/find_bit.c | 64 -- 1 file changed, 62 insertions(+), 2 deletions(-) diff --git