Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode

2020-10-09 Thread Peter Ujfalusi
On 09/10/2020 14.59, Nishanth Menon wrote: > On 10:43-20201009, Peter Ujfalusi wrote: >> Nishanth, >> >> On 09/10/2020 6.02, Nishanth Menon wrote: >>> On 14:52-20201008, Peter Ujfalusi wrote: - ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev, + ring->ring_mem_virt =

Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode

2020-10-09 Thread Nishanth Menon
On 10:43-20201009, Peter Ujfalusi wrote: > Nishanth, > > On 09/10/2020 6.02, Nishanth Menon wrote: > > On 14:52-20201008, Peter Ujfalusi wrote: > >> - ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev, > >> + ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev, > >>

Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode

2020-10-09 Thread Peter Ujfalusi
Nishanth, On 09/10/2020 6.02, Nishanth Menon wrote: > On 14:52-20201008, Peter Ujfalusi wrote: >> -ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev, >> +ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev, >> ring->size * (4 << ring->elm_size),

Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode

2020-10-08 Thread Nishanth Menon
On 14:52-20201008, Peter Ujfalusi wrote: > - ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev, > + ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev, > ring->size * (4 << ring->elm_size), > >ring_mem_dma,

[PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode

2020-10-08 Thread Peter Ujfalusi
In RING mode the ringacc does not access the ring memory. In this access mode the ringacc coherency does not have meaning. If the ring is configured in RING mode, then the ringacc itself will not access to the ring memory. Only the requester (user) of the ring is going to read/write to the