Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-04 Thread Josh Poimboeuf
On Thu, Jan 04, 2018 at 10:32:52AM -0600, Josh Poimboeuf wrote: > Either way we'll need to figure out a way to get objtool support ASAP. BTW, I got dwmw2's GCC patches but I'm about to disappear for a few days so it'll probably be next week before I get a chance to look at this. -- Josh

Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-04 Thread Josh Poimboeuf
On Thu, Jan 04, 2018 at 08:13:08AM -0800, Andi Kleen wrote: > On Thu, Jan 04, 2018 at 10:06:01AM -0600, Josh Poimboeuf wrote: > > On Thu, Jan 04, 2018 at 07:59:14AM -0800, Andi Kleen wrote: > > > > NAK. We can't blindly disable objtool warnings, that will break > > > > livepatch and the ORC unwind

Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-04 Thread Andi Kleen
On Thu, Jan 04, 2018 at 10:06:01AM -0600, Josh Poimboeuf wrote: > On Thu, Jan 04, 2018 at 07:59:14AM -0800, Andi Kleen wrote: > > > NAK. We can't blindly disable objtool warnings, that will break > > > livepatch and the ORC unwinder. If you share a .o file (or the GCC > > > code) I can look at ad

Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-04 Thread Josh Poimboeuf
On Thu, Jan 04, 2018 at 07:59:14AM -0800, Andi Kleen wrote: > > NAK. We can't blindly disable objtool warnings, that will break > > livepatch and the ORC unwinder. If you share a .o file (or the GCC > > code) I can look at adding retpoline support. > > I don't think we can wait for that. We can

Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-04 Thread Andi Kleen
> NAK. We can't blindly disable objtool warnings, that will break > livepatch and the ORC unwinder. If you share a .o file (or the GCC > code) I can look at adding retpoline support. I don't think we can wait for that. We can disable livepatch and the unwinder for now. They are not essential. Fr

Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-04 Thread David Woodhouse
On Thu, 2018-01-04 at 08:38 -0600, Josh Poimboeuf wrote: > > NAK.  We can't blindly disable objtool warnings, that will break > livepatch and the ORC unwinder.  If you share a .o file (or the GCC > code) I can look at adding retpoline support. http://git.infradead.org/users/dwmw2/gcc-retpoline.gi

Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-04 Thread Josh Poimboeuf
On Wed, Jan 03, 2018 at 06:00:18PM -0800, Andi Kleen wrote: > From: Andi Kleen > > With the indirect call thunk enabled compiler two objtool > warnings are triggered very frequently and make the build > very noisy. > > I don't see a good way to avoid them, so just disable them > for now. > > Si

[PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings

2018-01-03 Thread Andi Kleen
From: Andi Kleen With the indirect call thunk enabled compiler two objtool warnings are triggered very frequently and make the build very noisy. I don't see a good way to avoid them, so just disable them for now. Signed-off-by: Andi Kleen --- tools/objtool/check.c | 11 +++ 1 file cha