Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-11 Thread Milian Wolff
On Donnerstag, 10. August 2017 19:58:45 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > > > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: >

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-11 Thread Milian Wolff
On Donnerstag, 10. August 2017 19:58:45 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > > > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > > >> Agreed. Also I

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > >> Agreed. Also I guess no need to unwind anymore to get a srcfile for > >> an

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > >> Agreed. Also I guess no need to unwind anymore to get a srcfile for > >> an entry with your change. >

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Namhyung Kim
On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: >> Hi Milian, >> >> On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: >> > On one hand this ensures that the memory is properly freed when >>

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Namhyung Kim
On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: >> Hi Milian, >> >> On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: >> > On one hand this ensures that the memory is properly freed when >> > the DSO gets freed.

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Milian Wolff
On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: > > On one hand this ensures that the memory is properly freed when > > the DSO gets freed. On the other hand this significantly speeds up > > the

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Milian Wolff
On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: > > On one hand this ensures that the memory is properly freed when > > the DSO gets freed. On the other hand this significantly speeds up > > the

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-09 Thread Namhyung Kim
Hi Milian, On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: > On one hand this ensures that the memory is properly freed when > the DSO gets freed. On the other hand this significantly speeds up > the processing of the callchain nodes when lots of srclines are > requested. For one of

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-09 Thread Namhyung Kim
Hi Milian, On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: > On one hand this ensures that the memory is properly freed when > the DSO gets freed. On the other hand this significantly speeds up > the processing of the callchain nodes when lots of srclines are > requested. For one of

[PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-06 Thread Milian Wolff
On one hand this ensures that the memory is properly freed when the DSO gets freed. On the other hand this significantly speeds up the processing of the callchain nodes when lots of srclines are requested. For one of my data files e.g.: Before: Performance counter stats for 'perf report -s

[PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-06 Thread Milian Wolff
On one hand this ensures that the memory is properly freed when the DSO gets freed. On the other hand this significantly speeds up the processing of the callchain nodes when lots of srclines are requested. For one of my data files e.g.: Before: Performance counter stats for 'perf report -s