Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-17 Thread Jean-Francois Moine
On Sun, 12 Jan 2014 20:26:21 +0100 Sebastian Hesselbarth wrote: > On 01/12/2014 07:51 PM, Jean-Francois Moine wrote: > > On Sat, 11 Jan 2014 19:35:21 +0100 > > Sebastian Hesselbarth wrote: > > > >> At least for the DT part, I'd suggest to not ask for interrupt directly > >> but use a proper

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-17 Thread Jean-Francois Moine
On Sun, 12 Jan 2014 20:26:21 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 01/12/2014 07:51 PM, Jean-Francois Moine wrote: On Sat, 11 Jan 2014 19:35:21 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: At least for the DT part, I'd suggest to not

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-12 Thread Sebastian Hesselbarth
On 01/12/2014 07:51 PM, Jean-Francois Moine wrote: On Sat, 11 Jan 2014 19:35:21 +0100 Sebastian Hesselbarth wrote: At least for the DT part, I'd suggest to not ask for interrupt directly but use a proper gpios property. The can of course be converted to priv->int_irq in some tda998x_dt_probe.

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-12 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 19:35:21 +0100 Sebastian Hesselbarth wrote: > At least for the DT part, I'd suggest to not ask for interrupt directly > but use a proper gpios property. The can of course be converted to > priv->int_irq in some tda998x_dt_probe. May you give me more information? -- Ken ar

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-12 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 19:35:21 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: At least for the DT part, I'd suggest to not ask for interrupt directly but use a proper gpios property. The can of course be converted to priv-int_irq in some tda998x_dt_probe. May you give me

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-12 Thread Sebastian Hesselbarth
On 01/12/2014 07:51 PM, Jean-Francois Moine wrote: On Sat, 11 Jan 2014 19:35:21 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: At least for the DT part, I'd suggest to not ask for interrupt directly but use a proper gpios property. The can of course be converted to

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-11 Thread Sebastian Hesselbarth
On 01/11/2014 07:14 PM, Russell King - ARM Linux wrote: On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote: @@ -1250,6 +1311,39 @@ tda998x_encoder_init(struct i2c_client *client, priv->vip_cntrl_2 = video; } + /* install the optional HDMI connect

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-11 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote: > + if (priv->int_irq != NO_IRQ) { > + priv->wq_edid_wait = 1; > + i = wait_event_timeout(priv->wq_edid, > + !priv->wq_edid_wait, > +

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-11 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote: + if (priv-int_irq != NO_IRQ) { + priv-wq_edid_wait = 1; + i = wait_event_timeout(priv-wq_edid, + !priv-wq_edid_wait, +

Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-11 Thread Sebastian Hesselbarth
On 01/11/2014 07:14 PM, Russell King - ARM Linux wrote: On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote: @@ -1250,6 +1311,39 @@ tda998x_encoder_init(struct i2c_client *client, priv-vip_cntrl_2 = video; } + /* install the optional HDMI connect

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-09 Thread Jean-Francois Moine
This patch adds the optional treatment of the tda998x IRQ. The interrupt function is used to know the display connection status without polling and to speedup reading the EDID. Signed-off-by: Jean-Francois Moine --- drivers/gpu/drm/i2c/tda998x_drv.c| 116 +++--

[PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read

2014-01-09 Thread Jean-Francois Moine
This patch adds the optional treatment of the tda998x IRQ. The interrupt function is used to know the display connection status without polling and to speedup reading the EDID. Signed-off-by: Jean-Francois Moine moin...@free.fr --- drivers/gpu/drm/i2c/tda998x_drv.c| 116