Re: [PATCH v2 15/20] kvm: x86/mmu: Support dirty logging for the TDP MMU

2020-10-19 Thread Paolo Bonzini
On 19/10/20 19:07, Ben Gardon wrote: > On Fri, Oct 16, 2020 at 9:18 AM Paolo Bonzini wrote: >> >> On 14/10/20 20:26, Ben Gardon wrote: >>> >>> + if (kvm->arch.tdp_mmu_enabled) >>> + kvm_tdp_mmu_clear_dirty_pt_masked(kvm, slot, >>> + slot->base_gfn +

Re: [PATCH v2 15/20] kvm: x86/mmu: Support dirty logging for the TDP MMU

2020-10-19 Thread Ben Gardon
On Fri, Oct 16, 2020 at 9:18 AM Paolo Bonzini wrote: > > On 14/10/20 20:26, Ben Gardon wrote: > > > > + if (kvm->arch.tdp_mmu_enabled) > > + kvm_tdp_mmu_clear_dirty_pt_masked(kvm, slot, > > + slot->base_gfn + gfn_offset, mask, true); > > This was

Re: [PATCH v2 15/20] kvm: x86/mmu: Support dirty logging for the TDP MMU

2020-10-16 Thread Paolo Bonzini
On 14/10/20 20:26, Ben Gardon wrote: > > + if (kvm->arch.tdp_mmu_enabled) > + kvm_tdp_mmu_clear_dirty_pt_masked(kvm, slot, > + slot->base_gfn + gfn_offset, mask, true); This was "false" in v1, I need --verbose for this change. :) > while (mask)

[PATCH v2 15/20] kvm: x86/mmu: Support dirty logging for the TDP MMU

2020-10-14 Thread Ben Gardon
Dirty logging is a key feature of the KVM MMU and must be supported by the TDP MMU. Add support for both the write protection and PML dirty logging modes. Tested by running kvm-unit-tests and KVM selftests on an Intel Haswell machine. This series introduced no new failures. This series can be