Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-17 Thread Masahiro Yamada
2018-01-14 5:59 GMT+09:00 Wolfram Sang : > >> I am talking about the card detection >> by the IP-builtin circuit. > > Yes, I know. As I wrote in one of the previous patches when reviewing > it, I disabled GPIO CD and used the internal mechanism (for tests where > it is

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-17 Thread Masahiro Yamada
2018-01-14 5:59 GMT+09:00 Wolfram Sang : > >> I am talking about the card detection >> by the IP-builtin circuit. > > Yes, I know. As I wrote in one of the previous patches when reviewing > it, I disabled GPIO CD and used the internal mechanism (for tests where > it is relevant). Like here, too. >

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-13 Thread Wolfram Sang
> I am talking about the card detection > by the IP-builtin circuit. Yes, I know. As I wrote in one of the previous patches when reviewing it, I disabled GPIO CD and used the internal mechanism (for tests where it is relevant). Like here, too. > - GPIO is not set up ->

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-13 Thread Wolfram Sang
> I am talking about the card detection > by the IP-builtin circuit. Yes, I know. As I wrote in one of the previous patches when reviewing it, I disabled GPIO CD and used the internal mechanism (for tests where it is relevant). Like here, too. > - GPIO is not set up ->

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-05 Thread Masahiro Yamada
Hi Wolfram, 2018-01-03 2:13 GMT+09:00 Wolfram Sang : > >> > The TMIO mmc cannot detect the card insertion in native_hotplug mode >> > if the driver is probed without a card inserted. >> >> Hmm, it works for me without your patch just fine. Iam currently >> researching it... >

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-05 Thread Masahiro Yamada
Hi Wolfram, 2018-01-03 2:13 GMT+09:00 Wolfram Sang : > >> > The TMIO mmc cannot detect the card insertion in native_hotplug mode >> > if the driver is probed without a card inserted. >> >> Hmm, it works for me without your patch just fine. Iam currently >> researching it... > > It really doesn't

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-02 Thread Wolfram Sang
> > The TMIO mmc cannot detect the card insertion in native_hotplug mode > > if the driver is probed without a card inserted. > > Hmm, it works for me without your patch just fine. Iam currently > researching it... It really doesn't work for you? mmc_add_host -> mmc_start_host ->

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-02 Thread Wolfram Sang
> > The TMIO mmc cannot detect the card insertion in native_hotplug mode > > if the driver is probed without a card inserted. > > Hmm, it works for me without your patch just fine. Iam currently > researching it... It really doesn't work for you? mmc_add_host -> mmc_start_host ->

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-02 Thread Wolfram Sang
Yamada-san, > The TMIO mmc cannot detect the card insertion in native_hotplug mode > if the driver is probed without a card inserted. Hmm, it works for me without your patch just fine. Iam currently researching it... Happy new year, by the way! :) Regards, Wolfram signature.asc

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-02 Thread Wolfram Sang
Yamada-san, > The TMIO mmc cannot detect the card insertion in native_hotplug mode > if the driver is probed without a card inserted. Hmm, it works for me without your patch just fine. Iam currently researching it... Happy new year, by the way! :) Regards, Wolfram signature.asc

[PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2017-11-24 Thread Masahiro Yamada
The TMIO mmc cannot detect the card insertion in native_hotplug mode if the driver is probed without a card inserted. The reason is obvious; all IRQs are disabled by tmio_mmc_host_probe(), as follows: tmio_mmc_disable_mmc_irqs(_host, TMIO_MASK_ALL); The IRQs are first enabled by

[PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2017-11-24 Thread Masahiro Yamada
The TMIO mmc cannot detect the card insertion in native_hotplug mode if the driver is probed without a card inserted. The reason is obvious; all IRQs are disabled by tmio_mmc_host_probe(), as follows: tmio_mmc_disable_mmc_irqs(_host, TMIO_MASK_ALL); The IRQs are first enabled by