Re: [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure

2021-02-18 Thread Hector Martin
On 16/02/2021 03.06, Krzysztof Kozlowski wrote: On Mon, Feb 15, 2021 at 09:17:05PM +0900, Hector Martin wrote: +static void s3c64xx_serial_shutdown(struct uart_port *port) +{ + struct s3c24xx_uart_port *ourport = to_ourport(port); + + free_irq(port->irq, ourport); + +

Re: [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:05PM +0900, Hector Martin wrote: > Instead of patching a single global ops structure depending on the port > type, use a separate s3c64xx_serial_ops for the S3C64XX type. This > allows us to mark the structures as const. > > Also split out s3c64xx_serial_shutdown

[PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure

2021-02-15 Thread Hector Martin
Instead of patching a single global ops structure depending on the port type, use a separate s3c64xx_serial_ops for the S3C64XX type. This allows us to mark the structures as const. Also split out s3c64xx_serial_shutdown into a separate function now that we have a separate ops structure; this