Re: [PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type

2021-02-18 Thread Hector Martin
On 16/02/2021 03.26, Krzysztof Kozlowski wrote: This removes s3c24xx_serial_has_interrupt_mask, which was just checking for a specific type anyway, and adds the ucon_mask port info member to avoid having S3C2440 as a distinct type. Please split setting the ucon_mask to separate patch. It's a

Re: [PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:06PM +0900, Hector Martin wrote: > This decouples the TTY layer PORT_ types, which are exposed to > userspace, from the driver-internal flag of what kind of port this is. > > This removes s3c24xx_serial_has_interrupt_mask, which was just checking > for a specific

[PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type

2021-02-15 Thread Hector Martin
This decouples the TTY layer PORT_ types, which are exposed to userspace, from the driver-internal flag of what kind of port this is. This removes s3c24xx_serial_has_interrupt_mask, which was just checking for a specific type anyway, and adds the ucon_mask port info member to avoid having S3C2440