Re: [PATCH v2 2/2] ASoC: es7241: add es7241 codec support

2018-07-02 Thread Mark Brown
On Mon, Jul 02, 2018 at 12:15:03PM +0200, Jerome Brunet wrote: > On Mon, 2018-07-02 at 11:12 +0100, Mark Brown wrote: > > On Sat, Jun 30, 2018 at 07:22:41PM +0200, Jerome Brunet wrote: > > > + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > > > + case SND_SOC_DAIFMT_I2S: > > > + case SND_SOC_DAIFMT_

Re: [PATCH v2 2/2] ASoC: es7241: add es7241 codec support

2018-07-02 Thread Jerome Brunet
On Mon, 2018-07-02 at 11:12 +0100, Mark Brown wrote: > On Sat, Jun 30, 2018 at 07:22:41PM +0200, Jerome Brunet wrote: > > > + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > > + case SND_SOC_DAIFMT_I2S: > > + case SND_SOC_DAIFMT_LEFT_J: > > + break; > > These two modes are not the s

Re: [PATCH v2 2/2] ASoC: es7241: add es7241 codec support

2018-07-02 Thread Mark Brown
On Sat, Jun 30, 2018 at 07:22:41PM +0200, Jerome Brunet wrote: > + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > + case SND_SOC_DAIFMT_I2S: > + case SND_SOC_DAIFMT_LEFT_J: > + break; These two modes are not the same so either there should be some different handling to sele

[PATCH v2 2/2] ASoC: es7241: add es7241 codec support

2018-06-30 Thread Jerome Brunet
Add support for the everest es7241 which is a simple 2 channels analog to digital converter. Signed-off-by: Jerome Brunet --- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/es7241.c | 308 ++ 3 files changed, 314