On Fri, 13 Jun 2014, Antonio Ospite wrote:
> > Previously the tpkbd driver had various functions marked "_tp" to indicate
> > that it's for the "mouse" half of the keyboard as the kernel sees it,
> > however it does nothing special with the keyboard half. I was intending
> > (somewhat
On Thu, 12 Jun 2014 09:56:41 +0100 (BST)
Jamie Lentin wrote:
> On Wed, 11 Jun 2014, Antonio Ospite wrote:
>
[...]
> >> +static int tpcompactkbd_input_mapping(struct hid_device *hdev,
> >
> > Maybe name these functions like tpkbd_input_mapping_compact()?
> >
> > This way the namespace is more
On Thu, 12 Jun 2014 09:56:41 +0100 (BST)
Jamie Lentin j...@lentin.co.uk wrote:
On Wed, 11 Jun 2014, Antonio Ospite wrote:
[...]
+static int tpcompactkbd_input_mapping(struct hid_device *hdev,
Maybe name these functions like tpkbd_input_mapping_compact()?
This way the namespace is
On Fri, 13 Jun 2014, Antonio Ospite wrote:
Previously the tpkbd driver had various functions marked _tp to indicate
that it's for the mouse half of the keyboard as the kernel sees it,
however it does nothing special with the keyboard half. I was intending
(somewhat sloppily) to
On Wed, 11 Jun 2014, Antonio Ospite wrote:
On Tue, 10 Jun 2014 23:24:54 +0100
Jamie Lentin wrote:
Signed-off-by: Jamie Lentin
Some minor comments here too.
Thankyou for taking the time over both sets! All comments make sense.
---
drivers/hid/hid-core.c | 2 +
On Wed, 11 Jun 2014, Antonio Ospite wrote:
On Tue, 10 Jun 2014 23:24:54 +0100
Jamie Lentin j...@lentin.co.uk wrote:
Signed-off-by: Jamie Lentin j...@lentin.co.uk
Some minor comments here too.
Thankyou for taking the time over both sets! All comments make sense.
---
On Tue, 10 Jun 2014 23:24:54 +0100
Jamie Lentin wrote:
> Signed-off-by: Jamie Lentin
Some minor comments here too.
> ---
> drivers/hid/hid-core.c | 2 +
> drivers/hid/hid-ids.h | 2 +
> drivers/hid/hid-lenovo-tpkbd.c | 203
> +
>
On Tue, 10 Jun 2014 23:24:54 +0100
Jamie Lentin j...@lentin.co.uk wrote:
Signed-off-by: Jamie Lentin j...@lentin.co.uk
Some minor comments here too.
---
drivers/hid/hid-core.c | 2 +
drivers/hid/hid-ids.h | 2 +
drivers/hid/hid-lenovo-tpkbd.c | 203
Signed-off-by: Jamie Lentin
---
drivers/hid/hid-core.c | 2 +
drivers/hid/hid-ids.h | 2 +
drivers/hid/hid-lenovo-tpkbd.c | 203 +
include/linux/hid.h| 1 +
4 files changed, 208 insertions(+)
diff --git
Signed-off-by: Jamie Lentin j...@lentin.co.uk
---
drivers/hid/hid-core.c | 2 +
drivers/hid/hid-ids.h | 2 +
drivers/hid/hid-lenovo-tpkbd.c | 203 +
include/linux/hid.h| 1 +
4 files changed, 208 insertions(+)
diff --git
10 matches
Mail list logo
