Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
I will also update the comment for the other arch that using the similar description, such as ia64/metag/powerpc/sh/x86. Thanks, Li Bin on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin wrote: > >> There is no need to worry about module text disappearing

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin wrote: > >> There is no need to worry about module text disappearing case, >> because that ftrace has a module notifier that is called when >> a module is being unloaded and before the text goes away, and

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Steven Rostedt
On Fri, 4 Dec 2015 10:18:39 +0800 Li Bin wrote: > There is no need to worry about module text disappearing case, > because that ftrace has a module notifier that is called when > a module is being unloaded and before the text goes away, and this > code grabs the ftrace_lock mutex and removes the

[PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
There is no need to worry about module text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away, and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
I will also update the comment for the other arch that using the similar description, such as ia64/metag/powerpc/sh/x86. Thanks, Li Bin on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin wrote: > >> There is no need to worry about

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
on 2015/12/4 10:50, Steven Rostedt wrote: > On Fri, 4 Dec 2015 10:18:39 +0800 > Li Bin wrote: > >> There is no need to worry about module text disappearing case, >> because that ftrace has a module notifier that is called when >> a module is being unloaded and before

[PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Li Bin
There is no need to worry about module text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away, and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such that it will

Re: [PATCH v2 2/2] arm64: ftrace: fix the comments for ftrace_modify_code

2015-12-03 Thread Steven Rostedt
On Fri, 4 Dec 2015 10:18:39 +0800 Li Bin wrote: > There is no need to worry about module text disappearing case, > because that ftrace has a module notifier that is called when > a module is being unloaded and before the text goes away, and this > code grabs the