Re: [PATCH v2 2/2] drivers/serial: Add driver for Aspeed virtual UART

2017-04-09 Thread Joel Stanley
On Wed, Apr 5, 2017 at 8:24 PM, Andy Shevchenko wrote: > On Wed, Apr 5, 2017 at 7:03 AM, Joel Stanley wrote: > >> + port.port.irq = irq_of_parse_and_map(np, 0); > > Isn't better to get this via platform_get_irq() ? I can't see the benefit. > >>

Re: [PATCH v2 2/2] drivers/serial: Add driver for Aspeed virtual UART

2017-04-09 Thread Joel Stanley
On Wed, Apr 5, 2017 at 8:24 PM, Andy Shevchenko wrote: > On Wed, Apr 5, 2017 at 7:03 AM, Joel Stanley wrote: > >> + port.port.irq = irq_of_parse_and_map(np, 0); > > Isn't better to get this via platform_get_irq() ? I can't see the benefit. > >> + port.port.irqflags = IRQF_SHARED;

Re: [PATCH v2 2/2] drivers/serial: Add driver for Aspeed virtual UART

2017-04-05 Thread Andy Shevchenko
On Wed, Apr 5, 2017 at 7:03 AM, Joel Stanley wrote: > From: Jeremy Kerr > > This change adds a driver for the 16550-based Aspeed virtual UART > device. We use a similar process to the of_serial driver for device > probe, but expose some VUART-specific functions

Re: [PATCH v2 2/2] drivers/serial: Add driver for Aspeed virtual UART

2017-04-05 Thread Andy Shevchenko
On Wed, Apr 5, 2017 at 7:03 AM, Joel Stanley wrote: > From: Jeremy Kerr > > This change adds a driver for the 16550-based Aspeed virtual UART > device. We use a similar process to the of_serial driver for device > probe, but expose some VUART-specific functions through sysfs too. I would go

[PATCH v2 2/2] drivers/serial: Add driver for Aspeed virtual UART

2017-04-04 Thread Joel Stanley
From: Jeremy Kerr This change adds a driver for the 16550-based Aspeed virtual UART device. We use a similar process to the of_serial driver for device probe, but expose some VUART-specific functions through sysfs too. The VUART is two UART 'front ends' connected by their FIFO

[PATCH v2 2/2] drivers/serial: Add driver for Aspeed virtual UART

2017-04-04 Thread Joel Stanley
From: Jeremy Kerr This change adds a driver for the 16550-based Aspeed virtual UART device. We use a similar process to the of_serial driver for device probe, but expose some VUART-specific functions through sysfs too. The VUART is two UART 'front ends' connected by their FIFO (no actual serial