On 1/15/2015 4:35 AM, Nicolas Ferre wrote:
#define GEM_OTX 0x0100 /* Octets
transmitted */
I see, it's modified hereafter! Why not integrate this part in previous
patch?
I split these up the way I did by using the --fixup argument to allow the rebase
Le 14/01/2015 23:20, Xander Huff a écrit :
> Add spaces around arithmetic operators.
> Make a separate gem_ethtool_ops for the new statistics functions.
> Adjust new block comments to match the existing comments in macb.h.
I wouldn't have mixed the 3 modification in one patch.
More comments
On 1/15/2015 4:35 AM, Nicolas Ferre wrote:
#define GEM_OTX 0x0100 /* Octets
transmitted */
I see, it's modified hereafter! Why not integrate this part in previous
patch?
I split these up the way I did by using the --fixup argument to allow the rebase
Le 14/01/2015 23:20, Xander Huff a écrit :
Add spaces around arithmetic operators.
Make a separate gem_ethtool_ops for the new statistics functions.
Adjust new block comments to match the existing comments in macb.h.
I wouldn't have mixed the 3 modification in one patch.
More comments
Add spaces around arithmetic operators.
Make a separate gem_ethtool_ops for the new statistics functions.
Adjust new block comments to match the existing comments in macb.h.
Signed-off-by: Xander Huff
---
drivers/net/ethernet/cadence/macb.c | 25 +++--
drivers/net/ethernet/cadence/macb.h | 203
Add spaces around arithmetic operators.
Make a separate gem_ethtool_ops for the new statistics functions.
Adjust new block comments to match the existing comments in macb.h.
Signed-off-by: Xander Huff xander.h...@ni.com
---
drivers/net/ethernet/cadence/macb.c | 25 +++--
6 matches
Mail list logo
