Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Sakari Ailus
On Tue, Mar 13, 2018 at 11:16:33AM +, Rui Miguel Silva wrote: ... > > > +static int ov2680_gain_set(struct ov2680_dev *sensor, bool > > > auto_gain) > > > +{ > > > + struct ov2680_ctrls *ctrls = >ctrls; > > > + u32 gain; > > > + int ret; > > > + > > > + ret = ov2680_mod_reg(sensor,

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Sakari Ailus
On Tue, Mar 13, 2018 at 11:16:33AM +, Rui Miguel Silva wrote: ... > > > +static int ov2680_gain_set(struct ov2680_dev *sensor, bool > > > auto_gain) > > > +{ > > > + struct ov2680_ctrls *ctrls = >ctrls; > > > + u32 gain; > > > + int ret; > > > + > > > + ret = ov2680_mod_reg(sensor,

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Rui Miguel Silva
Hi Sakari, Thanks for the review... On Fri 09 Mar 2018 at 09:21, Sakari Ailus wrote: Hi Miguel, Thanks for the update. On Wed, Feb 28, 2018 at 03:27:23PM +, Rui Miguel Silva wrote: This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Rui Miguel Silva
Hi Sakari, Thanks for the review... On Fri 09 Mar 2018 at 09:21, Sakari Ailus wrote: Hi Miguel, Thanks for the update. On Wed, Feb 28, 2018 at 03:27:23PM +, Rui Miguel Silva wrote: This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-09 Thread Sakari Ailus
Hi Miguel, Thanks for the update. On Wed, Feb 28, 2018 at 03:27:23PM +, Rui Miguel Silva wrote: > This patch adds V4L2 sub-device driver for OV2680 image sensor. > The OV2680 is a 1/5" CMOS color sensor from Omnivision. > Supports output format: 10-bit Raw RGB. > The OV2680 has a single lane

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-09 Thread Sakari Ailus
Hi Miguel, Thanks for the update. On Wed, Feb 28, 2018 at 03:27:23PM +, Rui Miguel Silva wrote: > This patch adds V4L2 sub-device driver for OV2680 image sensor. > The OV2680 is a 1/5" CMOS color sensor from Omnivision. > Supports output format: 10-bit Raw RGB. > The OV2680 has a single lane

[PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-02-28 Thread Rui Miguel Silva
This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Supports output format: 10-bit Raw RGB. The OV2680 has a single lane MIPI interface. The driver exposes following V4L2 controls: - auto/manual exposure, - exposure, -

[PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-02-28 Thread Rui Miguel Silva
This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Supports output format: 10-bit Raw RGB. The OV2680 has a single lane MIPI interface. The driver exposes following V4L2 controls: - auto/manual exposure, - exposure, -