Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-07-10 Thread Johan Hovold
On Thu, Jul 06, 2017 at 01:59:08PM -0500, Dave Gerlach wrote: > On 07/03/2017 11:17 AM, Johan Hovold wrote: > > On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote: > >> Certain SoCs like Texas Instruments AM335x and AM437x require parts > >> of the EMIF PM code to run late in the suspend

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-07-06 Thread Dave Gerlach
On 07/03/2017 11:17 AM, Johan Hovold wrote: > On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote: >> Certain SoCs like Texas Instruments AM335x and AM437x require parts >> of the EMIF PM code to run late in the suspend sequence from SRAM, >> such as saving and restoring the EMIF context a

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-07-03 Thread Johan Hovold
On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote: > Certain SoCs like Texas Instruments AM335x and AM437x require parts > of the EMIF PM code to run late in the suspend sequence from SRAM, > such as saving and restoring the EMIF context and placing the memory > into self-refresh. > > O

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-06-20 Thread Dave Gerlach
Hi, On 06/20/2017 09:42 AM, Russell King - ARM Linux wrote: > On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote: >> +.arm >> +.align 3 >> + >> +ENTRY(ti_emif_sram) > > Will you ever want to have any of this code as Thumb? I cannot see any requirement for that. I will say it is

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-06-20 Thread Russell King - ARM Linux
On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote: > + .arm > + .align 3 > + > +ENTRY(ti_emif_sram) Will you ever want to have any of this code as Thumb? > +extern inline void ti_emif_offsets(void) > +{ "extern inline" is frowned upon in the kernel - any reason this can't be "

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-05-22 Thread Tony Lindgren
* Dave Gerlach [170519 11:00]: > diff --git a/arch/arm/kernel/asm-offsets.c b/arch/arm/kernel/asm-offsets.c > index 608008229c7d..d728b5660e36 100644 > --- a/arch/arm/kernel/asm-offsets.c > +++ b/arch/arm/kernel/asm-offsets.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include

[PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-05-19 Thread Dave Gerlach
Certain SoCs like Texas Instruments AM335x and AM437x require parts of the EMIF PM code to run late in the suspend sequence from SRAM, such as saving and restoring the EMIF context and placing the memory into self-refresh. One requirement for these SoCs to suspend and enter its lowest power mode,