Re: [PATCH v2 2/2] mm/gup: fix a misnamed "write" argument, and a related bug

2019-10-14 Thread Ira Weiny
On Mon, Oct 14, 2019 at 11:46:39AM -0700, John Hubbard wrote: > In several routines, the "flags" argument is incorrectly > named "write". Change it to "flags". > > Also, in one place, the misnaming led to an actual bug: > "flags & FOLL_WRITE" is required, rather than just "flags". > (That problem

[PATCH v2 2/2] mm/gup: fix a misnamed "write" argument, and a related bug

2019-10-14 Thread John Hubbard
In several routines, the "flags" argument is incorrectly named "write". Change it to "flags". Also, in one place, the misnaming led to an actual bug: "flags & FOLL_WRITE" is required, rather than just "flags". (That problem was flagged by krobot, in v1 of this patch.) Also, change the flags